Skip to content

Commit

Permalink
Add initial details about versions of dependencies (#912)
Browse files Browse the repository at this point in the history
Follow-up to #626 

This should complete dependency flow up Extensions from our partners.
  • Loading branch information
natemcmaster committed Jan 8, 2019
1 parent 604018c commit fd5d314
Show file tree
Hide file tree
Showing 8 changed files with 83 additions and 38 deletions.
10 changes: 10 additions & 0 deletions Directory.Build.props
Expand Up @@ -40,6 +40,16 @@
<SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>
</PropertyGroup>

<ItemGroup Condition=" '$(IsTestProject)' == 'true' ">
<Reference Include="Microsoft.AspNetCore.Testing" />
<Reference Include="Microsoft.NET.Test.Sdk" />
<Reference Include="Moq" />
<Reference Include="xunit" />
<Reference Include="xunit.analyzers" />
<Reference Include="xunit.runner.visualstudio" />
</ItemGroup>

<Import Project="eng\Versions.props" />
<Import Project="eng\Dependencies.props" />
<Import Project="eng\PatchConfig.props" />
<Import Project="eng\ProjectReferences.props" />
Expand Down
1 change: 0 additions & 1 deletion Directory.Build.targets
Expand Up @@ -5,7 +5,6 @@
<PackageOutputPath Condition="'$(IsProductComponent)' != 'true' ">$(InternalPackageOutputPath)</PackageOutputPath>

<RuntimeFrameworkVersion Condition=" '$(TargetFramework)' == 'netcoreapp3.0' ">$(MicrosoftNETCoreAppPackageVersion)</RuntimeFrameworkVersion>
<NETStandardImplicitPackageVersion Condition=" '$(TargetFramework)' == 'netstandard2.0' ">$(NETStandardLibrary20PackageVersion)</NETStandardImplicitPackageVersion>
</PropertyGroup>

<!-- Properties which should be set after the project has been evaluated -->
Expand Down
1 change: 1 addition & 0 deletions build/repo.props
@@ -1,4 +1,5 @@
<Project>
<Import Project="..\eng\Versions.props" />
<Import Project="..\eng\Dependencies.props" />

<PropertyGroup>
Expand Down
33 changes: 0 additions & 33 deletions eng/Dependencies.props
Expand Up @@ -3,31 +3,6 @@
<MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects>
</PropertyGroup>

<!-- These package versions may be overridden or updated by automation. -->
<PropertyGroup Label="Package Versions: Auto">
<InternalAspNetCoreSdkPackageVersion>3.0.0-build-20190105.1</InternalAspNetCoreSdkPackageVersion>
<MicrosoftNETCoreAppPackageVersion>3.0.0-preview-27204-02</MicrosoftNETCoreAppPackageVersion>
<MicrosoftWin32RegistryPackageVersion>4.6.0-preview.18604.2</MicrosoftWin32RegistryPackageVersion>
<NETStandardLibrary20PackageVersion>2.0.3</NETStandardLibrary20PackageVersion>
<SystemComponentModelAnnotationsPackageVersion>4.6.0-preview.18604.2</SystemComponentModelAnnotationsPackageVersion>
<SystemDataSqlClientPackageVersion>4.7.0-preview.18604.2</SystemDataSqlClientPackageVersion>
<SystemDiagnosticsDiagnosticSourcePackageVersion>4.6.0-preview.18604.2</SystemDiagnosticsDiagnosticSourcePackageVersion>
<SystemDiagnosticsEventLogPackageVersion>4.6.0-preview.18604.2</SystemDiagnosticsEventLogPackageVersion>
<SystemIOPipelinesPackageVersion>4.6.0-preview.18604.2</SystemIOPipelinesPackageVersion>
<SystemMemoryPackageVersion>4.5.2-servicing-27114-05</SystemMemoryPackageVersion>
<SystemNetHttpPackageVersion>4.3.2</SystemNetHttpPackageVersion>
<SystemReflectionMetadataPackageVersion>1.7.0-preview.18604.2</SystemReflectionMetadataPackageVersion>
<SystemRuntimeCompilerServicesUnsafePackageVersion>4.6.0-preview.18604.2</SystemRuntimeCompilerServicesUnsafePackageVersion>
<SystemRuntimeInteropServicesRuntimeInformationPackageVersion>4.3.0</SystemRuntimeInteropServicesRuntimeInformationPackageVersion>
<SystemSecurityCryptographyCngPackageVersion>4.6.0-preview.18604.2</SystemSecurityCryptographyCngPackageVersion>
<SystemSecurityCryptographyXmlPackageVersion>4.6.0-preview.18604.2</SystemSecurityCryptographyXmlPackageVersion>
<SystemTextEncodingsWebPackageVersion>4.6.0-preview.18604.2</SystemTextEncodingsWebPackageVersion>
<SystemThreadingTasksExtensionsPackageVersion>4.6.0-preview.18604.2</SystemThreadingTasksExtensionsPackageVersion>
<SystemValueTuplePackageVersion>4.5.0</SystemValueTuplePackageVersion>
</PropertyGroup>

<!-- This may import a generated file which may override the variables above. -->
<Import Project="$(DotNetPackageVersionPropsPath)" Condition=" '$(DotNetPackageVersionPropsPath)' != '' " />
<ItemGroup Label=".NET Core dependencies">
<LatestPackageReference Include="Microsoft.Win32.Registry" Version="$(MicrosoftWin32RegistryPackageVersion)" />
<LatestPackageReference Include="System.ComponentModel.Annotations" Version="$(SystemComponentModelAnnotationsPackageVersion)" />
Expand Down Expand Up @@ -90,12 +65,4 @@
<LatestPackageReference Include="Unity.Microsoft.DependencyInjection" Version="2.1.3" />
</ItemGroup>

<ItemGroup Condition=" '$(IsTestProject)' == 'true' ">
<Reference Include="Microsoft.AspNetCore.Testing" />
<Reference Include="Microsoft.NET.Test.Sdk" />
<Reference Include="Moq" />
<Reference Include="xunit" />
<Reference Include="xunit.analyzers" />
<Reference Include="xunit.runner.visualstudio" />
</ItemGroup>
</Project>
55 changes: 54 additions & 1 deletion eng/Version.Details.xml
@@ -1,6 +1,59 @@
<?xml version="1.0" encoding="utf-8"?>
<Dependencies>
<ProductDependencies></ProductDependencies>
<ProductDependencies>
<Dependency Name="Microsoft.Win32.Registry" Version="4.6.0-preview.18604.2">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>000000</Sha>
</Dependency>
<Dependency Name="System.ComponentModel.Annotations" Version="4.6.0-preview.18604.2">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>000000</Sha>
</Dependency>
<Dependency Name="System.Data.SqlClient" Version="4.7.0-preview.18604.2">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>000000</Sha>
</Dependency>
<Dependency Name="System.Diagnostics.DiagnosticSource" Version="4.6.0-preview.18604.2">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>000000</Sha>
</Dependency>
<Dependency Name="System.Diagnostics.EventLog" Version="4.6.0-preview.18604.2">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>000000</Sha>
</Dependency>
<Dependency Name="System.IO.Pipelines" Version="4.6.0-preview.18604.2">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>000000</Sha>
</Dependency>
<Dependency Name="System.Reflection.Metadata" Version="1.7.0-preview.18604.2">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>000000</Sha>
</Dependency>
<Dependency Name="System.Runtime.CompilerServices.Unsafe" Version="4.6.0-preview.18604.2">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>000000</Sha>
</Dependency>
<Dependency Name="System.Security.Cryptography.Cng" Version="4.6.0-preview.18604.2">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>000000</Sha>
</Dependency>
<Dependency Name="System.Security.Cryptography.Xml" Version="4.6.0-preview.18604.2">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>000000</Sha>
</Dependency>
<Dependency Name="System.Text.Encodings.Web" Version="4.6.0-preview.18604.2">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>000000</Sha>
</Dependency>
<Dependency Name="System.Threading.Tasks.Extensions" Version="4.6.0-preview.18604.2">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>000000</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.App" Version="3.0.0-preview-27204-02">
<Uri>https://github.com/dotnet/core-setup</Uri>
<Sha>00000</Sha>
</Dependency>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="1.0.0-beta.18630.2">
<Uri>https://github.com/dotnet/arcade</Uri>
Expand Down
18 changes: 18 additions & 0 deletions eng/Versions.props
@@ -1,6 +1,24 @@

<Project>
<PropertyGroup>
<InternalAspNetCoreSdkPackageVersion>3.0.0-build-20190105.1</InternalAspNetCoreSdkPackageVersion>
<MicrosoftDotNetBuildTasksFeedVersion>2.2.0-beta.18607.6</MicrosoftDotNetBuildTasksFeedVersion>
<MicrosoftNETCoreAppPackageVersion>3.0.0-preview-27204-02</MicrosoftNETCoreAppPackageVersion>
<MicrosoftWin32RegistryPackageVersion>4.6.0-preview.18604.2</MicrosoftWin32RegistryPackageVersion>
<SystemComponentModelAnnotationsPackageVersion>4.6.0-preview.18604.2</SystemComponentModelAnnotationsPackageVersion>
<SystemDataSqlClientPackageVersion>4.7.0-preview.18604.2</SystemDataSqlClientPackageVersion>
<SystemDiagnosticsDiagnosticSourcePackageVersion>4.6.0-preview.18604.2</SystemDiagnosticsDiagnosticSourcePackageVersion>
<SystemDiagnosticsEventLogPackageVersion>4.6.0-preview.18604.2</SystemDiagnosticsEventLogPackageVersion>
<SystemIOPipelinesPackageVersion>4.6.0-preview.18604.2</SystemIOPipelinesPackageVersion>
<SystemMemoryPackageVersion>4.5.2</SystemMemoryPackageVersion>
<SystemNetHttpPackageVersion>4.3.2</SystemNetHttpPackageVersion>
<SystemReflectionMetadataPackageVersion>1.7.0-preview.18604.2</SystemReflectionMetadataPackageVersion>
<SystemRuntimeCompilerServicesUnsafePackageVersion>4.6.0-preview.18604.2</SystemRuntimeCompilerServicesUnsafePackageVersion>
<SystemRuntimeInteropServicesRuntimeInformationPackageVersion>4.3.0</SystemRuntimeInteropServicesRuntimeInformationPackageVersion>
<SystemSecurityCryptographyCngPackageVersion>4.6.0-preview.18604.2</SystemSecurityCryptographyCngPackageVersion>
<SystemSecurityCryptographyXmlPackageVersion>4.6.0-preview.18604.2</SystemSecurityCryptographyXmlPackageVersion>
<SystemTextEncodingsWebPackageVersion>4.6.0-preview.18604.2</SystemTextEncodingsWebPackageVersion>
<SystemThreadingTasksExtensionsPackageVersion>4.6.0-preview.18604.2</SystemThreadingTasksExtensionsPackageVersion>
<SystemValueTuplePackageVersion>4.5.0</SystemValueTuplePackageVersion>
</PropertyGroup>
</Project>
1 change: 0 additions & 1 deletion eng/publish.proj
Expand Up @@ -2,7 +2,6 @@
<Project DefaultTargets="Publish">

<Import Project="..\Directory.Build.props" />
<Import Project="Versions.props" />

<PropertyGroup>
<AssetManifestFilePath>$(ArtifactsDir)AssetManifest\$(OS)-$(Configuration).xml</AssetManifestFilePath>
Expand Down
2 changes: 0 additions & 2 deletions eng/tools.proj
@@ -1,8 +1,6 @@
<!-- Temporary: copying this file from Arcade here to unblock dependency flow. Once we convert to Arcade, this can be removed. -->
<Project Sdk="Microsoft.NET.Sdk">

<Import Project="Versions.props" />

<PropertyGroup>
<TargetFramework>net462</TargetFramework>
</PropertyGroup>
Expand Down

0 comments on commit fd5d314

Please sign in to comment.