Skip to content
This repository has been archived by the owner on Nov 6, 2018. It is now read-only.

Using [NotNull] #109

Closed
wants to merge 1 commit into from
Closed

Using [NotNull] #109

wants to merge 1 commit into from

Conversation

hishamco
Copy link
Contributor

No description provided.

This was referenced Jun 12, 2015
Merged
Closed
@hishamco
Copy link
Contributor Author

/cc @Eilon

@Eilon
Copy link
Member

Eilon commented Jun 18, 2015

Tests are failing due to this change. Please not that [NotNull] is not yet implemented, so if you pass null into such a parameter it will be allowed, and the method will likely have a NullReferenceException. So for now I'll keep this PR open because I don't want to change any product code or tests to account for this missing feature.

@hishamco
Copy link
Contributor Author

@Eilon can you please mark this as Blocked until the [NotNull] is implemented, to avoid close it by mistake

@Eilon
Copy link
Member

Eilon commented Jun 26, 2015

Don't worry it won't get randomly closed 😄

@hishamco
Copy link
Contributor Author

I didn't mean you 😄 but this tag will notify the others this PR blocking something else, you can see aspnet/Identity#485

@muratg
Copy link

muratg commented Sep 4, 2015

Closing this one as we are discussing our approach to Null checks.

@muratg muratg closed this Sep 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hishamco @Eilon @muratg @dnfclas