Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Create a standard server feature interface for listing & configuring server prefixes and/or ports #331

Closed
Tratcher opened this issue Aug 14, 2015 · 5 comments

Comments

@Tratcher
Copy link
Member

Depends on #329

Once we have this then Hosting can use it to Console.WriteLine each address after IServerFactory.Start. See #328

@Tratcher
Copy link
Member Author

Recomendation:

public interface IServerAddressesFeature
{
  IList<string> Addresses { get; }
}

@davidfowl
Copy link
Member

Feels like we should break it into parts

@Tratcher
Copy link
Member Author

We had a long discussion on that. The server may support a variety of formats, so only it can really break it into meaningful parts. e.g. http vs unix sockets vs named pipes, etc..

Note Add may have some normalization, like "8080" turning into "http://*:8080/". Add may also throw if you give it unrecognized formats.

@davidfowl
Copy link
Member

We also need to support the --port flag. Should that be another issue?

@Tratcher
Copy link
Member Author

We had the idea today to directly support ports in server.uls. If you just provided an int then we would assume you meant http://*:port/ (or localhost?). The same goes for the IServerAddressesFeature.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants