This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Create a scoped service provider for the call to Configure #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This allows scoped dependencies to be injected into the Configure method. It means you can resolve the DbContext or any other scoped service without the hassle of the CreateScope boiler plate. As a side effect, it also makes Startup.Configure a bit more testable.
pakrym
reviewed
Jun 18, 2017
|
|
||
| public class DisposableService : IDisposable | ||
| { | ||
| public bool Disposed { get; set; } |
There was a problem hiding this comment.
Were you going to use this?
There was a problem hiding this comment.
Yea, but it's impossible to get to at the instance. I can remove it.
|
@pakrym one question I had, do we have a DI spec test that create "nested scopes". Scopes aren't nested in our container but will anything blow up if somebody was creating a scope on top of an existing scoped |
pakrym
reviewed
Jun 18, 2017
| app.ApplicationServices = startup.ConfigureServicesDelegate(serviceCollection); | ||
| startup.ConfigureDelegate(app); | ||
|
|
||
| var instance = (StartupWithScopedServices)startup.StartupInstance; |
There was a problem hiding this comment.
You could've just registered factory and stored last created object.
|
Should we also have a DI spec test showing |
2 tasks
mguinness
added a commit
to mguinness/ZNetCS.AspNetCore.Logging.EntityFrameworkCore
that referenced
this pull request
Dec 5, 2018
See aspnet/Hosting#1106 for details.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It means you can resolve the DbContext or any other scoped service without
the hassle of the CreateScope boiler plate. As a side effect, it also makes
Startup.Configure a bit more testable.
Inspired by issues like aspnet/Mvc#6407 and code like in our template that needs to create a scope in order to run db init logic.
One downside of this change. If you hold onto scoped services past the
Configuremethod, they'll explode later. While this would have exploded by default in the new templates, it now works.