Use System.Buffers #550
Use System.Buffers #550
Conversation
|
Seeing all of these hardcoded statics worry me a bit. I think we should pass the arraypool in the ctor and have overloads that use the shared one by default. |
|
Changed BufferPool so it can be overridden from Shared for everything except |
|
Alas doesn't address #548 as FileBufferingReadStream is more messy and if you give MemoryStream a starting buffer its fixed size; so would need to do an extra step in the progressive upgrade |
|
Actually.... |
|
Travis fail is a "too many open files" issue on OSX |
|
Raised issue for decoding https://github.com/dotnet/corefx/issues/5888 |
| @@ -51,6 +74,14 @@ public class FileBufferingReadStream : Stream | |||
| // TODO: allow for an optional buffer size limit to prevent filling hard disks. 1gb? | |||
| public FileBufferingReadStream(Stream inner, int memoryThreshold, string tempFileDirectory) | |||
|
|
||
| if ((ch & 0xFF80) == 0) | ||
| { | ||
| helper.AddByte((byte)ch); // 7 bit have to go as bytes because of Unicode |
There was a problem hiding this comment.
Brain explodes... I liked it better when I didn't have to know how the decoder worked.
There was a problem hiding this comment.
Kept it private so can push it back into corefx at somepoint
|
Made feedback changes |
|
@rynowak How do you want to verify this? |
|
Superseded by #556 ? |
|
Pre-for 3,000 requests 44MB on MemoryStream
Post for 30,000 requests - |
Resolves #545
Added System.Buffer
Extra
Now also resolves #548
...except when content is buffered to disk; which needs this issue resolving in corefx https://github.com/dotnet/corefx/issues/5598
Due to
FileStream's internal buffer is not being exposed/settable.