Skip to content
This repository has been archived by the owner on Mar 19, 2019. It is now read-only.

Chunked encoding when formatters write out the response #61

Closed
kichalla opened this issue Aug 31, 2014 · 6 comments
Closed

Chunked encoding when formatters write out the response #61

kichalla opened this issue Aug 31, 2014 · 6 comments

Comments

@kichalla
Copy link
Member

I know that this is a known thing for a while now...but adding this bug however to keep track of this...
also the behavior is different from Helios in this matter...

When formatters write out the response on Helios, they are not sent out as chunked encoded, but they are in case of weblistener...

@davidfowl
Copy link
Member

What does this have to do with formatters specifically?

@kichalla
Copy link
Member Author

As part of the PR aspnet/Mvc#1074 , we explicitly avoid flushing to prevent chunked encoding...but this works only for Helios..

line of interest: https://github.com/aspnet/Mvc/blob/6adf8faff124ead324824b94b2e037daa5d4d3da/src/Microsoft.AspNet.Mvc.Core/Formatters/DelegatingStream.cs#L128

@davidfowl
Copy link
Member

What's about kestel? And apache and ngix? I'm pretty sure that if you want consistent behavior across servers the solution needs to be at a higher layer.

Also, isn't this a more general question about buffering?

@kichalla
Copy link
Member Author

Right, this is in general related to buffering at hosts...

I haven't tested with those hosts yet...


From: David Fowlermailto:notifications@github.com
Sent: ý8/ý31/ý2014 12:34 PM
To: aspnet/WebListenermailto:WebListener@noreply.github.com
Cc: Kiran Challamailto:kichalla@microsoft.com
Subject: Re: [WebListener] Chunked encoding when formatters write out the response (#61)

What's about kestel? And apache and ngix? I'm pretty sure that if you want consistent behavior across servers the solution needs to be at a higher layer.

Also, isn't this a more general question about buffering?


Reply to this email directly or view it on GitHubhttps://github.com//issues/61#issuecomment-53998785.

@kichalla
Copy link
Member Author

oops..by "buffering at hosts", i didn't really mean host-specific but as you mentioned something higher would keep it consistent across all hosts...

@Tratcher
Copy link
Member

@kichalla, please move this bug to https://github.com/aspnet/Hosting.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants