Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

[automated] Merge branch 'release/2.2' => 'master' #2041

Conversation

dotnet-maestro-bot
Copy link

I detected changes in the release/2.2 branch which have not been merged yet to master. I'm a robot and am configured to help you automatically keep master up to date, so I've opened this PR.

This PR merges commits made on release/2.2 by the following committers:

Instructions for merging

This PR will not be auto-merged. When pull request checks pass, please complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

You can also do this on command line:

git checkout -b merge/release/2.2-to-master master
git pull https://github.com/dotnet-maestro-bot/Identity merge/release/2.2-to-master
git checkout master
git merge --no-ff merge/release/2.2-to-master
git push origin master

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/2.2-to-master'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.

git checkout -b merge/release/2.2-to-master master
git pull https://github.com/dotnet-maestro-bot/Identity merge/release/2.2-to-master
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet-maestro-bot/Identity merge/release/2.2-to-master

Please contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.

* Block enabled 2fa in the UI without cookie consent

* Guard against feature not being there

* Set up tweak

* Fix
@Eilon Eilon requested a review from HaoK October 31, 2018 22:01
@Eilon
Copy link
Member

Eilon commented Oct 31, 2018

@HaoK - please merge ASAP.

@dotnet-maestro-bot
Copy link
Author

This pull request has been updated.

This PR merges commits made on release/2.2 by the following committers:

@HaoK
Copy link
Member

HaoK commented Nov 1, 2018

@javiercn I guess I should let you do this merge now since you have way more changes, I don't think mine should cause any conflicts, let me know if you have any issues

@javiercn
Copy link
Member

javiercn commented Nov 1, 2018

I resolved the conflict, I'll merge once the build passes

@javiercn
Copy link
Member

javiercn commented Nov 1, 2018

Superseeded by #2047

@javiercn javiercn closed this Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants