This repository has been archived by the owner on Dec 20, 2018. It is now read-only.
Updating stores to use TypeDescriptor for type conversion #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
|
Maybe make this change for Options as well? 
|
sure I can do that. |
|
@HaoK |
|
Bleh leave options alone then |
|
ok |
|
@divega Reminder |
| @@ -12,6 +12,7 @@ | |||
| "dependencies": { | |||
| "System.Collections": "4.0.10-beta-*", | |||
| "System.ComponentModel": "4.0.0-beta-*", | |||
There was a problem hiding this comment.
Just in case, do we still the one above?
|
|
|
Had a chat with @divega and we'll be adding this to Options as well. Will send it in a separate PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@HaoK @divega
Fix for #420
The
TypeDescriptorclass is available in both desktop and core clr so taking this change. Verified it functionally. Removed the existing code in functional tests which was causing it pass incorrectly so now we have coverage there as well