Adding support for capturing the output of a node instance for custom…

[pauldotknopf]

… logging implementations.

Not all implementations rely on stdout for logging and error messages.

[laskoviymishka]

Great point, best way to handle it IMHO to replace every Console.WriteLine to ILogger.Write, and inject logger from DI. Does it make sense for you?

[pauldotknopf]

The INodeInstances are created via new (see here). No room for DI there.

[pauldotknopf]

Are you referring to using the Microsoft libraries for logging?

[laskoviymishka]

Yep, it is. And yep it need to be refactored :)

[SteveSandersonMS]

Thanks @pauldotknopf! This is now merged (commit 27ffa7).

Instead of the custom INodeInstanceOutputLogger, as as per @laskoviymishka's comments, I've done a bit of further work to make it use the standard .NET ILogger interface, and to integrate it with DI.

The various INodeInstance subclasses now require you to pass an ILogger to them, and the DI-based instantiation flow uses the service provider to get an ILogger according to your config. If no logger is configured, it falls back on ConsoleLogger.

Hope this meets your needs, but please let me know if you have any concerns.

I haven't yet actually published updated NuGet packages containing this, as I'm waiting first to see if anyone thinks there's any problem with this.