chore(typescript): Upgrade to 2.0 & Types #258

MarkPieszak · 2016-08-12T20:29:52Z

! Work in progress !

Upgraded all Project Templates to TS2.0beta, @types, removed all remnants of tsd, typings folders, etc.
Left Universal specific custom types in types/custom-types.d.ts for the ng2 template.

Note: TypeScript2 is still in beta, Visual Studio / VSCode / etc need to be setup to realize they're using a beta/nightly build of TypeScript to take advantage of 2.0 features.

Tested & Working:

Angular2Spa
KnockoutSpa
ReactSpa
WebApplicationBasic

WIP Issues :

ReactReduxSpa

it looks like the project needs to be updated to the latest API, @types here cause many errors, since its based on an older API.

[ ](Issues remaining with certain react @types / Store / Dispatch)
- node_modules/redux-typed/StrongActions.d.ts (16,16): error TS2314: Generic type 'Dispatch<S>' requires 1 type argument(s). (can be fixed with PR Update aspnet-webpack-react to React 15 #256 )
- @types/react-router-redux/index.d.ts error TS2305: Module '"history"' has no exported member 'LocationDescriptor'. (possible Type definition issue? Opened here)
- ./ClientApp/boot-client.tsx error TS2322: Type 'ReactRouterReduxHistory' is not assignable to type 'History'. Property 'listenBefore' is missing in type 'ReactRouterReduxHistory'.

ERROR in C:\Users\mark.pieszak\Documents\GitHub\JavaScriptServices\templates\ReactReduxSpa\node_modules\redux-typed\StrongActions.d.ts
(16,16): error TS2314: Generic type 'Dispatch~~' requires 1 type argument(s).~~

ERROR in C:\Users\mark.pieszak\Documents\GitHub\JavaScriptServices\templates\ReactReduxSpa\types\custom-types.d.ts
(7,1): error TS2688: Cannot find type definition file for 'react-router/history.d.ts'.

ERROR in ./ClientApp/configureStore.ts
(12,39): error TS2346: Supplied parameters do not match any signature of call target.

ERROR in ./ClientApp/configureStore.ts
(19,75): error TS2686: Identifier 'Redux' must be imported from a module

ERROR in ./ClientApp/configureStore.ts
(19,75): error TS2314: Generic type 'Store~~' requires 1 type argument(s).~~

ERROR in ./ClientApp/configureStore.ts
(33,91): error TS2686: Identifier 'Redux' must be imported from a module

SteveSandersonMS · 2016-08-17T20:52:09Z

Thanks for this! I'll merge it as soon as TypeScript 2.0 ships. It will be great to get all those .d.ts files out of the project 👍

MarkPieszak · 2016-08-18T00:09:45Z

Glad to help 😄
Sounds like a plan!
Doing some finishes touches on the PR at the moment. Almost finished testing & fixing all the templates.

# Conflicts: # templates/Angular2Spa/package.json # templates/KnockoutSpa/tsd.json # templates/KnockoutSpa/typings/tsd.d.ts # templates/ReactReduxSpa/package.json # templates/ReactSpa/tsd.json # templates/ReactSpa/typings/tsd.d.ts

MarkPieszak · 2016-09-16T15:39:23Z

Just fixed the merged conflicts, @SteveSandersonMS
Can we merge this before merging the Angular2 final + Universal updates?

stephtr · 2016-09-18T09:59:16Z

If it helps: "error TS2686: Identifier 'Redux' must be imported from a module" seems to be related with TypeScript #10638. Using typescript@2.1.0-dev.20160918 or the Release-2.0-branch these errors vanish.

"(12,39): error TS2346: Supplied parameters do not match any signature of call target" can be fixed by changing windowIfDefined.devToolsExtension to
windowIfDefined.devToolsExtension as () => (a: any) => any or better: () => GenericStoreEnhancer

MarkPieszak · 2016-09-18T15:56:39Z

Thank you @stephtr I'll take a look! I wasn't sure if we would want to use typescript@next since it cold e very unstable though?

The supplied parameters one is because compose is using a very old type definition from tsd, when upgrading to types it's using the newest redux, so we need to reconfigure the API :(
Hoping I can spend some time with Steve to look through the ReactRedux changes needed.

Other than that, I was able to get all the other projects running without errors luckily.

colltoaction · 2016-09-18T16:21:54Z

Maybe you can take a look at @types if you're updating to Typescript 2 :)

On Sun, Sep 18, 2016, 12:56 Mark Pieszak notifications@github.com wrote:

Thank you @stephtr https://github.com/stephtr I'll take a look! I
wasn't sure if we would want to use typescript@next since it cold e very
unstable though?

One of the other main problems is that the store API in the one project is
very outdated model (based on an old tsd commit). Hoping I can spend some
time with Steve to look through the ReactRedux changes needed.

Other than that, I was able to get all the other projects running without
errors luckily.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#258 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABeg9FXMArS5aaCZmpDCayWTDxSYbfUrks5qrV8-gaJpZM4JjbwR
.

MarkPieszak · 2016-09-18T16:52:22Z

Course! Already have them in here 😃

stephtr · 2016-09-18T19:39:45Z

One change made in Redux 3.6 is Improve typings for compose function, therefore a type definition is needed for devToolsExtension.

Using only a few changes ReactReduxSpa runs using TypeScript 2.0 (typescript@next not necessary) and @types.

While experimenting I noticed that TypeScript seems to use the typing included in the redux-package and not from @types/redux.

types/custom-types.d.ts is not needed when including node_modules/@types/webpack/webpack-env.d.ts in tsconfig.json (see DefinitelyTyped #10578).

MarkPieszak · 2016-09-26T09:39:24Z

Hoping to get back to this one later today so we can get this merged in there since TS2 finally shipped :)
@SteveSandersonMS maybe we can link up later to figure out those ReactRedux issues? Seems the API has changed quite a bit for compose and a few other things.

antmdvs

Added comments for ReactReduxSpa

antmdvs · 2016-09-30T20:52:07Z

templates/ReactReduxSpa/ClientApp/configureStore.ts

@@ -4,6 +4,7 @@ import { routerReducer } from 'react-router-redux';
 import * as Store from './store';
 import { typedToPlain } from 'redux-typed';

+
 export default function configureStore(initialState?: Store.ApplicationState) {
    // Build middleware. These are functions that can process the actions before they reach the store.
    const thunk = (thunkModule as any).default; // Workaround for TypeScript not importing thunk module as expected


I don't think this workaround is needed anymore and I believe you can just:
import thunk from 'redux-thunk';

antmdvs · 2016-09-30T21:04:34Z

templates/ReactReduxSpa/package.json

@@ -1,7 +1,18 @@
 {
-  "name": "WebApplicationBasic",
+  "name": "react-redux-spa",
  "version": "0.0.0",
  "dependencies": {


Not sure why I can't comment on line 40 (it's grayed out), but bump typescript to v2.
"typescript": "^2.0.3",

Great idea! Let me add that in there.

stephtr · 2016-09-30T22:32:27Z

Which issues are still left (except redux-typed)? Because in my fork it is working (stephtr/JavaScriptServices).

MarkPieszak · 2016-10-05T16:16:39Z

Closed in favor of #362

MarkPieszak added 3 commits August 3, 2016 13:02

chore(github): Add Github templates

be2ba2b

Merge remote-tracking branch 'aspnet/dev' into dev

c81c19d

chore(typescript) Upgrade to 2.0 & Types

1e04b22

dnfclas added the cla-already-signed label Aug 12, 2016

MarkPieszak added 2 commits August 15, 2016 02:19

Delete ISSUE_TEMPLATE.md

bc3069a

Delete PULL_REQUEST_TEMPLATE.md

0e18a64

geirsagberg mentioned this pull request Aug 16, 2016

Update aspnet-webpack-react to React 15 #256

Closed

MarkPieszak added 3 commits August 18, 2016 00:22

Update to use TS2 lib capability - no need for es6 or core-js

d9f3686

Added custom types for universal

b5d9d1f

Multiple TS fixes

801cbf6

MarkPieszak mentioned this pull request Aug 28, 2016

Consider using Typings instead of TSD in templates #285

Closed

Updates - still working on ReactReduxSpa example

f637594

MarkPieszak mentioned this pull request Sep 17, 2016

Update to Angular2 Final #257

Closed

MarkPieszak mentioned this pull request Sep 30, 2016

Update to Typescript 2.0.x in template projects #342

Closed

antmdvs reviewed Sep 30, 2016

View reviewed changes

MarkPieszak mentioned this pull request Oct 2, 2016

Move tsconfig.json files to template root folders #346

Closed

MarkPieszak closed this Oct 5, 2016

snyk-bot mentioned this pull request Jul 17, 2020

[Snyk] Fix for 1 vulnerabilities harunpehlivan/JavaScriptServices#23

Open

snyk-bot mentioned this pull request Jul 17, 2020

[Snyk] Fix for 1 vulnerabilities harunpehlivan/JavaScriptServices#24

Open

snyk-bot mentioned this pull request Sep 2, 2021

[Snyk] Security upgrade style-loader from 0.18.2 to 0.20.0 harunpehlivan/JavaScriptServices#51

Open

snyk-bot mentioned this pull request Nov 10, 2021

[Snyk] Fix for 1 vulnerabilities harunpehlivan/JavaScriptServices#59

Open

harunpehlivan mentioned this pull request Nov 5, 2022

[Snyk] Fix for 1 vulnerabilities harunpehlivan/JavaScriptServices#82

Open

snyk-bot mentioned this pull request Dec 26, 2022

[Snyk] Fix for 1 vulnerabilities harunpehlivan/JavaScriptServices#90

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(typescript): Upgrade to 2.0 & Types #258

chore(typescript): Upgrade to 2.0 & Types #258

MarkPieszak commented Aug 12, 2016 •

edited

Loading

SteveSandersonMS commented Aug 17, 2016

MarkPieszak commented Aug 18, 2016

MarkPieszak commented Sep 16, 2016

stephtr commented Sep 18, 2016 •

edited

Loading

MarkPieszak commented Sep 18, 2016 •

edited

Loading

colltoaction commented Sep 18, 2016

MarkPieszak commented Sep 18, 2016

stephtr commented Sep 18, 2016 •

edited

Loading

MarkPieszak commented Sep 26, 2016

antmdvs left a comment

antmdvs Sep 30, 2016 •

edited

Loading

antmdvs Sep 30, 2016

MarkPieszak Oct 1, 2016

stephtr commented Sep 30, 2016 •

edited

Loading

MarkPieszak commented Oct 5, 2016

chore(typescript): Upgrade to 2.0 & Types #258

chore(typescript): Upgrade to 2.0 & Types #258

Conversation

MarkPieszak commented Aug 12, 2016 • edited Loading

! Work in progress !

Tested & Working:

WIP Issues :

ReactReduxSpa

SteveSandersonMS commented Aug 17, 2016

MarkPieszak commented Aug 18, 2016

MarkPieszak commented Sep 16, 2016

stephtr commented Sep 18, 2016 • edited Loading

MarkPieszak commented Sep 18, 2016 • edited Loading

colltoaction commented Sep 18, 2016

MarkPieszak commented Sep 18, 2016

stephtr commented Sep 18, 2016 • edited Loading

MarkPieszak commented Sep 26, 2016

antmdvs left a comment

Choose a reason for hiding this comment

antmdvs Sep 30, 2016 • edited Loading

Choose a reason for hiding this comment

antmdvs Sep 30, 2016

Choose a reason for hiding this comment

MarkPieszak Oct 1, 2016

Choose a reason for hiding this comment

stephtr commented Sep 30, 2016 • edited Loading

MarkPieszak commented Oct 5, 2016

MarkPieszak commented Aug 12, 2016 •

edited

Loading

stephtr commented Sep 18, 2016 •

edited

Loading

MarkPieszak commented Sep 18, 2016 •

edited

Loading

stephtr commented Sep 18, 2016 •

edited

Loading

antmdvs Sep 30, 2016 •

edited

Loading

stephtr commented Sep 30, 2016 •

edited

Loading