This repository has been archived by the owner on Apr 8, 2020. It is now read-only.
Update to Angular 4 (phase 1) #930
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import { NgModule } from '@angular/core'; | ||
| import { BrowserModule } from '@angular/platform-browser'; | ||
| import { FormsModule } from '@angular/forms'; | ||
| import { HttpModule } from '@angular/http'; | ||
| import { sharedConfig } from './app.module'; | ||
|
|
||
| @NgModule({ | ||
| bootstrap: sharedConfig.bootstrap, | ||
| declarations: sharedConfig.declarations, | ||
| imports: [ | ||
| BrowserModule, | ||
|
There was a problem hiding this comment. You want to make sure you have |
||
| FormsModule, | ||
| HttpModule, | ||
| ...sharedConfig.imports | ||
| ], | ||
| providers: [ | ||
| { provide: 'ORIGIN_URL', useValue: location.origin } | ||
| ] | ||
| }) | ||
| export class AppModule { | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import { NgModule } from '@angular/core'; | ||
| import { ServerModule } from '@angular/platform-server'; | ||
| import { sharedConfig } from './app.module'; | ||
|
|
||
| @NgModule({ | ||
| bootstrap: sharedConfig.bootstrap, | ||
| declarations: sharedConfig.declarations, | ||
| imports: [ | ||
| ServerModule, | ||
|
There was a problem hiding this comment. You want to make sure you have BrowserModule with serverTransition here as well (with the same appId) |
||
| ...sharedConfig.imports | ||
| ] | ||
| }) | ||
| export class AppModule { | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,22 @@ | ||
| import 'reflect-metadata'; | ||
| import 'zone.js'; | ||
|
There was a problem hiding this comment. You could just have (I believe it's a bit smaller) |
||
| import { enableProdMode } from '@angular/core'; | ||
| import { platformBrowserDynamic } from '@angular/platform-browser-dynamic'; | ||
| import { AppModule } from './app/app.module.client'; | ||
|
|
||
| if (module['hot']) { | ||
| module['hot'].accept(); | ||
| module['hot'].dispose(() => { | ||
| // Before restarting the app, we create a new root element and dispose the old one | ||
| const oldRootElem = document.querySelector('app'); | ||
| const newRootElem = document.createElement('app'); | ||
| oldRootElem.parentNode.insertBefore(newRootElem, oldRootElem); | ||
| modulePromise.then(appModule => appModule.destroy()); | ||
| }); | ||
| } else { | ||
| enableProdMode(); | ||
| } | ||
|
|
||
| // Note: @ng-tools/webpack looks for the following expression when performing production | ||
| // builds. Don't change how this line looks, otherwise you may break tree-shaking. | ||
| const modulePromise = platformBrowserDynamic().bootstrapModule(AppModule); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,36 @@ | ||
| import 'reflect-metadata'; | ||
| import 'zone.js'; | ||
| import 'rxjs/add/operator/first'; | ||
| import { enableProdMode, ApplicationRef, NgZone, ValueProvider } from '@angular/core'; | ||
| import { platformDynamicServer, PlatformState, INITIAL_CONFIG } from '@angular/platform-server'; | ||
| import { createServerRenderer, RenderResult } from 'aspnet-prerendering'; | ||
| import { AppModule } from './app/app.module.server'; | ||
|
|
||
| enableProdMode(); | ||
|
|
||
| export default createServerRenderer(params => { | ||
| const providers = [ | ||
| { provide: INITIAL_CONFIG, useValue: { document: '<app></app>', url: params.url } }, | ||
| { provide: 'ORIGIN_URL', useValue: params.origin } | ||
| ]; | ||
|
|
||
| return platformDynamicServer(providers).bootstrapModule(AppModule).then(moduleRef => { | ||
|
There was a problem hiding this comment. The team has stressed to never use dynamicServer as JIT compilation just slows down server renders tremendously as you'd really only want ahead of time compiled ones with Just worried we might have Devs use this phase 1 template (and never update it) and get stuck using a non-ideal bootstrapModule serializer. There was a problem hiding this comment. That's a good point as for where we're ultimately heading, but right now people are already using the equivalent to There was a problem hiding this comment. Great! Just making sure :) |
||
| const appRef = moduleRef.injector.get(ApplicationRef); | ||
| const state = moduleRef.injector.get(PlatformState); | ||
| const zone = moduleRef.injector.get(NgZone); | ||
|
|
||
| return new Promise<RenderResult>((resolve, reject) => { | ||
| zone.onError.subscribe(errorInfo => reject(errorInfo)); | ||
| appRef.isStable.first(isStable => isStable).subscribe(() => { | ||
| // Because 'onStable' fires before 'onError', we have to delay slightly before | ||
| // completing the request in case there's an error to report | ||
| setImmediate(() => { | ||
| resolve({ | ||
| html: state.renderToString() | ||
| }); | ||
| moduleRef.destroy(); | ||
| }); | ||
| }); | ||
|
There was a problem hiding this comment. You could catch errors here in the subscription |
||
| }); | ||
| }); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make more sense to have sharedConfig be an
NgModuleitself that they import withinimports[], since most Apps will have lots of NgModules lazy-loaded etc ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. How does that then work in terms of overriding the config in each of the server/client app modules? If you can post a code sample we can definitely consider this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW I tried to do this, but hit a roadblock. If the shared
NgModuleincludes the routing config (which of course you would want it to), then it has to be able to compile all the templates for all the components. But to be able to compile them, it needs to reference eitherBrowserModuleorServerModule(otherwise it fails with errors likengIf is unknown). But it can't reference either of those, because it needs to work with both server and client.So is there any reasonable way to do this? Please let me know if there is. It doesn't seem like a compiled
NgModulecan possibly be portable across both server and client, which is an unfortunate limitation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry just seeing this now! @SteveSandersonMS
Did you have boot-client & boot-server using browser-app.module & server-app.module ?
To get rid of the ngIf unknown errors, you just import CommonModule into your base app.module NgModule (https://github.com/MarkPieszak/aspnetcore-angular2-universal/blob/master/Client/app/app.module.ts#L51)
You can see in there I have the app.module importing the Routes, and all the base declarations etc that can be shared. Browser & Server-app.module's both import the app.module and they each declare the
bootstrap: [ AppComponent ]themselves. You want to make sure app.module doesn't declare a bootstrap Component.