Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Consume BindingAddress in ServerAddress #2230

Closed
jkotalik opened this issue Dec 20, 2017 · 0 comments
Closed

Consume BindingAddress in ServerAddress #2230

jkotalik opened this issue Dec 20, 2017 · 0 comments
Labels
3 - Done task
Milestone
2.2.0-preview3

Comments

@jkotalik
Copy link
Contributor

HttpAbstractions has a new type that will be consumed for using the IServerAddressFeature. Though Kestrel cannot remove the ServerAddress type, we can deprecate it and then start using the BindingAddress internally. Kestrel will also have to throw if the PathBase is set before consuming the type.
@muratg muratg added the up-for-grabs We will consider contributions label Feb 21, 2018
@muratg muratg added this to the Backlog milestone Feb 21, 2018
SonicGD added a commit to SonicGD/KestrelHttpServer that referenced this issue Oct 2, 2018
@SonicGD
aspnet#2230 Mark ServerAddress as obsolete
736c434
SonicGD added a commit to SonicGD/KestrelHttpServer that referenced this issue Oct 2, 2018
@SonicGD
aspnet#2230 suppress CS0618 errors for obsoleted ServerAddress class
fffec58
SonicGD added a commit to SonicGD/KestrelHttpServer that referenced this issue Oct 2, 2018
@SonicGD
aspnet#2230 Use BindingAddress instead of ServerAddress
131fdbd
@SonicGD SonicGD mentioned this issue Oct 2, 2018
Merged
SonicGD added a commit to SonicGD/KestrelHttpServer that referenced this issue Oct 5, 2018
@SonicGD
aspnet#2230 Mark ServerAddress as obsolete
74310ed
SonicGD added a commit to SonicGD/KestrelHttpServer that referenced this issue Oct 5, 2018
@SonicGD
aspnet#2230 suppress CS0618 errors for obsoleted ServerAddress class
28b8bec
SonicGD added a commit to SonicGD/KestrelHttpServer that referenced this issue Oct 5, 2018
@SonicGD
aspnet#2230 Use BindingAddress instead of ServerAddress
bcdcbda
Tratcher pushed a commit that referenced this issue Oct 5, 2018
@SonicGD @Tratcher
Implement #2230 - Consume BindingAddress instead of ServerAddress (#2975
e9eea50 
)

* #2230 Mark ServerAddress as obsolete

* #2230 suppress CS0618 errors for obsoleted ServerAddress class

* #2230 Use BindingAddress instead of ServerAddress
@Tratcher Tratcher added 3 - Done task and removed up-for-grabs We will consider contributions labels Oct 5, 2018
@Tratcher Tratcher modified the milestones: Backlog, 2.2.0-preview3 Oct 5, 2018
@Tratcher Tratcher closed this as completed Oct 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
3 - Done task
Projects
None yet
Milestone
2.2.0-preview3
Development

No branches or pull requests
3 participants
@muratg @Tratcher @jkotalik