Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Add keep-alive timeout parameter #464

Closed
benaadams opened this issue Dec 9, 2015 · 8 comments
Closed

Add keep-alive timeout parameter #464

benaadams opened this issue Dec 9, 2015 · 8 comments

Comments

@benaadams
Copy link
Contributor

No description provided.

@muratg
Copy link
Contributor

muratg commented Dec 9, 2015

Yeah, I think we should do this.

cc @lodejard

@benaadams benaadams changed the title Add keep-alive timeout Add keep-alive timeout Parameter Dec 14, 2015
@muratg muratg added this to the 1.0.0-rc2 milestone Dec 21, 2015
@muratg
Copy link
Contributor

muratg commented Dec 21, 2015

@benaadams It looks like you're working on this. Looking forward to see the PR!

@cesarblum
Copy link
Contributor

@benaadams Are you working on this? I guess not since it's been 21 days since @muratg's comment 😄 I'll take this if no one's working on it.

@benaadams
Copy link
Contributor Author

@CesarBS I was quite close with #485 though it needs rebasing; I can finish it of with improves if you can workout #569? Haven't managed to work out what's going on there.

On our priorities, we do need the keep-alive for our production use, so will move onto this now.

@cesarblum
Copy link
Contributor

@benaadams I can't look into #569 immediately, so go ahead with #485 as it is right now.

@DamianEdwards
Copy link
Member

post RC2

@darrelmiller
Copy link

It would be nice if this could be called "ConnectionTimeout" instead of Keep-Alive timeout. IIS calls it ConnectionTimeout. By calling it Keep-Alive timeout there is an inference that is somehow related to the HTTP/1.0 extension keep-alive header and the failed attempt to resurrect it for a different purpose..

Admittedly though, Apache does call it KeepAliveTimeout

cesarblum pushed a commit that referenced this issue Sep 6, 2016
@cesarblum cesarblum changed the title Add keep-alive timeout Parameter Add keep-alive timeout parameter Sep 6, 2016
@cesarblum
Copy link
Contributor

@darrelmiller It might happen #1102 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants