Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Improve request line parsing #683

Closed
cesarblum opened this issue Mar 9, 2016 · 1 comment
Closed

Improve request line parsing #683

cesarblum opened this issue Mar 9, 2016 · 1 comment
Assignees
@cesarblum
Labels
3 - Done enhancement task
Milestone
1.0.0

Comments

@cesarblum
Copy link
Contributor

cesarblum commented Mar 9, 2016 •
edited

Check for:

  • Invalid/missing method
  • Invalid/missing target
  • Invalid/missing HTTP version
  • Missing CR LF

Should return 400 for all except invalid HTTP version, which should be 505 (#712).
@cesarblum cesarblum self-assigned this Mar 9, 2016
@muratg muratg modified the milestones: 1.0.0-rc2, 1.0.0 Mar 9, 2016
@cesarblum cesarblum changed the title Simplify TakeStartLine by checking if input is available before parsing Make TakeStartLine more robust Apr 29, 2016
@cesarblum
Copy link
Contributor Author

Updated the issue to reflect new reality.

This was referenced Apr 29, 2016
Closed
Closed
Merged
cesarblum pushed a commit that referenced this issue May 12, 2016
Make TakeStartLine more robust (#683).
3186e1b
@cesarblum cesarblum changed the title Make TakeStartLine more robust Improve request line parsing May 16, 2016
@cesarblum cesarblum mentioned this issue May 16, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cesarblum cesarblum

Labels
3 - Done enhancement task
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@cesarblum @muratg