Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Don't bind if only port is specified. #814

Closed
Tratcher opened this issue May 9, 2016 · 3 comments
Closed

Don't bind if only port is specified. #814

Tratcher opened this issue May 9, 2016 · 3 comments
Assignees
@mikeharder
Labels
3 - Done bug
Milestone
1.0.0

Comments

@Tratcher
Copy link
Member

Tratcher commented May 9, 2016

You can pass just a port integer into Kestrel as the address to bind to. Currently Kestrel assumes this means to bind to the given port publicly for all IPs. https://github.com/aspnet/KestrelHttpServer/blob/dev/src/Microsoft.AspNetCore.Server.Kestrel/ServerAddress.cs#L87

Kestrel should only bind to localhost unless explicitly specified. Note WebListener already behaves this way.
@Tratcher Tratcher added the bug label May 9, 2016
@Tratcher Tratcher added this to the 1.0.0 milestone May 9, 2016
@Tratcher
Copy link
Member Author

Tratcher commented May 9, 2016

https://github.com/aspnet/WebListener/blob/dev/src/Microsoft.Net.Http.Server/UrlPrefix.cs#L128

@muratg muratg changed the title Bind to localhost when only given a port Don't bind if only port is specified. May 18, 2016
@Tratcher
Copy link
Member Author

Change of plans (as reflected in the title). Remove support for only specifying the port. People make bad assumptions about the rest of the prefix.

@Tratcher Tratcher mentioned this issue May 20, 2016
Closed
mikeharder added a commit that referenced this issue May 21, 2016
@mikeharder
Don't bind if only port is specified (#814)
cf575aa
mikeharder added a commit that referenced this issue May 21, 2016
@mikeharder
Don't bind if only port is specified (#814)
d16c2d4 
- Also renamed ServerAddressFacts to ServerAddressTests to match existing test classes
@mikeharder mikeharder mentioned this issue May 21, 2016
Merged
@mikeharder
Copy link
Contributor

Since this is a breaking change, I plan to create an issue under https://github.com/aspnet/Announcements after this is merged.

mikeharder added a commit that referenced this issue May 23, 2016
@mikeharder
Don't bind if only port is specified (#814)
224427a 
- Also renamed ServerAddressFacts to ServerAddressTests to match existing test classes
mikeharder added a commit that referenced this issue May 23, 2016
@mikeharder
Don't bind if only port is specified (#814) (#861)
5ca6592 
- Also renamed ServerAddressFacts to ServerAddressTests to match existing test classes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mikeharder mikeharder

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@Tratcher @mikeharder