Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Read after connection error can throw two different exception types #975

Closed
cesarblum opened this issue Jul 15, 2016 · 0 comments
Closed

Read after connection error can throw two different exception types #975

cesarblum opened this issue Jul 15, 2016 · 0 comments
Assignees
@cesarblum
Labels
3 - Done bug
Milestone
1.1.0-preview1

Comments

@cesarblum
Copy link
Contributor

  • IOException: thrown if ReadAsync is awaiting on SocketInput when the connection is aborted.
  • TaskCanceledException: thrown if ReadAsync is called by the time the connection has already been aborted after an error.

Need to make this consistent and return only one type of exception.
@cesarblum cesarblum added the bug label Jul 15, 2016
@cesarblum cesarblum self-assigned this Jul 15, 2016
@cesarblum cesarblum added this to the 1.1.0 milestone Jul 15, 2016
cesarblum pushed a commit that referenced this issue Jul 15, 2016
Always throw same exception type on read after connection error (#975).
68251fe
@cesarblum cesarblum mentioned this issue Jul 16, 2016
Merged
cesarblum pushed a commit that referenced this issue Jul 21, 2016
Always throw same exception type on read after connection error (#975).
02e8908
cesarblum pushed a commit that referenced this issue Jul 21, 2016
Always throw same exception type on read after connection error (#975).
3c0e0f8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cesarblum cesarblum

Labels
3 - Done bug
Projects
None yet
Milestone
1.1.0-preview1
Development

No branches or pull requests
1 participant
@cesarblum