Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Measure Writing in FrameWritingBenchmark #1642

Closed
wants to merge 2 commits into from

Conversation

benaadams
Copy link
Contributor

@benaadams benaadams commented Apr 9, 2017

Wasn't really measuring the actual writing path before
Also was incorrectly measuring sync vs async by adding an additional await in the async path

/cc @davidfowl

@benaadams
Copy link
Contributor Author

Output (minus StdDev, Median)

     Method | WithHeaders | Chunked | OnStarting |        Mean |       Op/s | Allocated |
----------- |------------ |-------- |----------- |------------ |----------- |---------- |
 WriteAsync |       False |   False |      Async | 138.8264 ns | 7203239.23 |      78 B |
 WriteAsync |       False |   False |       None | 139.5984 ns | 7163404.47 |      78 B |
 WriteAsync |       False |   False |       Sync | 142.2543 ns | 7029662.80 |      78 B |
 WriteAsync |       False |    True |      Async | 140.8392 ns | 7100294.58 |      78 B |
 WriteAsync |       False |    True |       None | 140.9036 ns | 7097048.48 |      78 B |
 WriteAsync |       False |    True |       Sync | 140.8301 ns | 7100756.97 |      78 B |
 WriteAsync |        True |   False |      Async | 635.7148 ns | 1573032.43 |     306 B |
 WriteAsync |        True |   False |       None | 527.2127 ns | 1896767.50 |     178 B |
 WriteAsync |        True |   False |       Sync | 632.5463 ns | 1580911.93 |     306 B |
 WriteAsync |        True |    True |      Async | 629.4966 ns | 1588570.92 |     306 B |
 WriteAsync |        True |    True |       None | 524.1801 ns | 1907741.15 |     178 B |
 WriteAsync |        True |    True |       Sync | 632.1967 ns | 1581786.05 |     306 B |

@davidfowl
Copy link
Member

@pakrym Does this look ok to you?

@muratg
Copy link
Contributor

muratg commented Aug 15, 2017

ping @pakrym

@pakrym
Copy link
Contributor

pakrym commented Aug 15, 2017

Closing, please reopen if we are going to do performance work in this area.

@pakrym pakrym closed this Aug 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants