This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Set Content-Length: 0 when an AppFunc completes without a write #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previously an incomplete chunked response would be written instead. - Add test to verify Content-Length: 0 is set automatically. - Add test to verify HTTP/1.0 keep-alive isn't used if no Content-Length is set for the response. - Add tests to verify errors are handled properly after chunked writes. #173
|
|
1 similar comment
|
|
- When in response to a HEAD Request - For 101, 204, 205 and 304 responses - For non keep-alive connections
halter73
force-pushed
the
shalter/empty-response
branch
from
ce5276e
to
2642c84
Compare
|
I took a look at WebListener like @Tratcher suggested. I pulled the list of status codes not to send |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is set for the response.
Responses will never complete if nothing is written to the response body #173