Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

Add missing packages to M.A.All #21

Closed
2 of 4 tasks
JunTaoLuo opened this issue Apr 5, 2017 · 11 comments
Closed
2 of 4 tasks

Add missing packages to M.A.All #21

JunTaoLuo opened this issue Apr 5, 2017 · 11 comments
Assignees

Comments

@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Apr 5, 2017

Tracking issues regarding inclusion of our packages in the metapackage:

JunTaoLuo added a commit that referenced this issue Apr 7, 2017
@DamianEdwards
Copy link
Member

It also needs all the toolish dependency packages, e.g. Microsoft.AspNetCore.Mvc.Razor.ViewCompilation, Microsoft.EntityFrameworkCore.Design, etc.

@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Apr 20, 2017

Parsing from the packages.csv (which should be updated since we plan on making that the source of truth) #19

To be included:

Microsoft.AspNetCore,ship,exclude
Microsoft.AspNetCore.Mvc.Razor.ViewCompilation,ship,exclude
Microsoft.EntityFrameworkCore.Design,ship,exclude
Microsoft.EntityFrameworkCore.Relational.Design,ship,exclude
Microsoft.EntityFrameworkCore.Sqlite.Design,ship,exclude
Microsoft.EntityFrameworkCore.SqlServer.Design,ship,exclude
Microsoft.EntityFrameworkCore.Tools,ship,exclude
Microsoft.Extensions.Caching.Redis,ship,exclude
Microsoft.VisualStudio.Web.BrowserLink,ship,exclude

Not included:

Pre-release:

Microsoft.AspNetCore.Buffering,noship,exclude
Microsoft.AspNetCore.DataProtection.Redis,noship,exclude
Microsoft.AspNetCore.Diagnostics.Elm,noship,exclude
Microsoft.AspNetCore.Diagnostics.Identity.Service,noship,exclude
Microsoft.AspNetCore.Identity.Service.Core,noship,exclude
Microsoft.AspNetCore.Identity.Service.Abstractions,noship,exclude
Microsoft.AspNetCore.Identity.Service,noship,exclude
Microsoft.AspNetCore.Identity.Service.EntityFrameworkCore,noship,exclude
Microsoft.AspNetCore.Identity.Service.IntegratedWebClient,noship,exclude
Microsoft.AspNetCore.Identity.Service.Mvc,noship,exclude
Microsoft.AspNetCore.Proxy,noship,exclude
Microsoft.AspNetCore.WebSockets.Internal,noship,exclude
Microsoft.Extensions.WebSockets.Internal,noship,exclude

net451/net46 packages:

Microsoft.AspNet.Identity.AspNetCoreCompat,ship,exclude
Microsoft.AspNetCore.AzureAppServices.SiteExtension,noship,exclude
Microsoft.AspNetCore.DataProtection.SystemWeb,ship,exclude
Microsoft.AspNetCore.Hosting.WindowsServices,ship,exclude
Microsoft.CodeAnalysis.Remote.Razor,ship,exclude
Microsoft.Extensions.Logging.EventLog,ship,include
Microsoft.Owin.Security.Interop,ship,exclude
Microsoft.VisualStudio.LanguageServices.Razor,noship,exclude
Microsoft.Web.Xdt.Extensions,noship,exclude

Metapackages:

Microsoft.AspNetCore.All,ship,exclude

Tools:

Microsoft.CodeAnalysis.Razor.Workspaces,ship,exclude
Microsoft.DotNet.Watcher.Tools,ship,exclude
Microsoft.EntityFrameworkCore.Tools.DotNet,ship,exclude
Microsoft.Extensions.Caching.SqlConfig.Tools,ship,exclude
Microsoft.Extensions.SecretManager.Tools,ship,exclude
Microsoft.VisualStudio.Web.CodeGeneration,ship,exclude
Microsoft.VisualStudio.Web.CodeGeneration.Contracts,ship,exclude
Microsoft.VisualStudio.Web.CodeGeneration.Core,ship,exclude
Microsoft.VisualStudio.Web.CodeGeneration.Design,ship,exclude
Microsoft.VisualStudio.Web.CodeGeneration.EntityFrameworkCore,ship,exclude
Microsoft.VisualStudio.Web.CodeGeneration.Templating,ship,exclude
Microsoft.VisualStudio.Web.CodeGeneration.Tools,ship,exclude
Microsoft.VisualStudio.Web.CodeGeneration.Utils,ship,exclude
Microsoft.VisualStudio.Web.CodeGenerators.Mvc,ship,exclude

Sources:

Microsoft.AspNetCore.ChunkingCookieManager.Sources,noship,exclude
Microsoft.AspNetCore.RangeHelper.Sources,noship,exclude
Microsoft.AspNetCore.Razor.TagHelpers.Testing.Sources,noship,exclude
Microsoft.AspNetCore.Routing.DecisionTree.Sources,noship,exclude
Microsoft.Extensions.ActivatorUtilities.Sources,noship,exclude
Microsoft.Extensions.ClosedGenericMatcher.Sources,noship,exclude
Microsoft.Extensions.CommandLineUtils.Sources,noship,exclude
Microsoft.Extensions.CopyOnWriteDictionary.Sources,noship,exclude
Microsoft.Extensions.HashCodeCombiner.Sources,noship,exclude
Microsoft.Extensions.Process.Sources,noship,exclude
Microsoft.Extensions.PropertyActivator.Sources,noship,exclude
Microsoft.Extensions.PropertyHelper.Sources,noship,exclude
Microsoft.Extensions.RazorViews.Sources,noship,exclude
Microsoft.Extensions.RuntimeEnvironment.Sources,noship,exclude
Microsoft.Extensions.SecurityHelper.Sources,noship,exclude
Microsoft.Extensions.StackTrace.Sources,noship,exclude
Microsoft.Extensions.TaskCache.Sources,noship,exclude
Microsoft.Extensions.TypeNameHelper.Sources,noship,exclude
Microsoft.Extensions.WebEncoders.Sources,noship,exclude

Testing:

Microsoft.AspNetCore.Identity.Specification.Tests,ship,exclude
Microsoft.AspNetCore.Server.IntegrationTesting,noship,exclude
Microsoft.AspNetCore.TestHost,ship,exclude
Microsoft.AspNetCore.Testing,noship,exclude
Microsoft.EntityFrameworkCore.Relational.Design.Specification.Tests,ship,exclude
Microsoft.EntityFrameworkCore.Relational.Specification.Tests,ship,exclude
Microsoft.EntityFrameworkCore.Specification.Tests,ship,exclude
Microsoft.Extensions.DependencyInjection.Specification.Tests,ship,exclude
Microsoft.Extensions.Logging.Testing,noship,exclude

Other:

RazorPageGenerator,noship,exclude

@JunTaoLuo
Copy link
Contributor Author

ping @DamianEdwards

@DamianEdwards
Copy link
Member

This list looks good

@danroth27
Copy link
Member

These packages should be included and flipped to shipping for preview1 in the .csv:

Microsoft.AspNetCore.Diagnostics.Identity.Service
Microsoft.AspNetCore.Identity.Service.Core
Microsoft.AspNetCore.Identity.Service.Abstractions
Microsoft.AspNetCore.Identity.Service
Microsoft.AspNetCore.Identity.Service.EntityFrameworkCore
Microsoft.AspNetCore.Identity.Service.IntegratedWebClient
Microsoft.AspNetCore.Identity.Service.Mvc

@danroth27
Copy link
Member

aspnet/Coherence#196

@JunTaoLuo
Copy link
Contributor Author

Ignore previous comment, posted to wrong issue.

@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Apr 26, 2017

The only remaining issue is Azure/azure-sdk-for-net#3003. Blocking inclusion of Microsoft.Extensions.Configuration.AzureKeyVault. Keeping issue to track.

@DamianEdwards
Copy link
Member

I just realized you have packages listed in the "Tools" section above that aren't. Namely Microsoft.VisualStudio.Web.CodeGeneration.Design and friends. They go in the project file as dependencies. Best bet is to look at the templates and use that as the guide.

@JunTaoLuo
Copy link
Contributor Author

The rest of the packages have been added in #71. Keeping open to track azure key vault package.

@JunTaoLuo
Copy link
Contributor Author

Azure key vault added.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants