Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Commit

Permalink
Remove cyclic dependency between Mvc and Scaffolding
Browse files Browse the repository at this point in the history
  • Loading branch information
@pranavkm
pranavkm committed Jul 27, 2016
1 parent 0a5f8e0 commit cad72e7
Showing 1 changed file with 3 additions and 21 deletions.
24 changes: 3 additions & 21 deletions samples/MvcSandbox/project.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,7 @@
"Microsoft.AspNetCore.Server.Kestrel": "1.1.0-*",
"Microsoft.AspNetCore.StaticFiles": "1.1.0-*",
"Microsoft.Extensions.Configuration.Json": "1.1.0-*",
"Microsoft.Extensions.Logging.Console": "1.1.0-*",
"Microsoft.VisualStudio.Web.CodeGeneration.Tools": {
"type": "build",
"version": "1.0.0-*"
},
"Microsoft.VisualStudio.Web.CodeGenerators.Mvc": {
"type": "build",
"version": "1.0.0-*"
}
"Microsoft.Extensions.Logging.Console": "1.1.0-*"
},
"publishOptions": {
"include": [
Expand All @@ -34,13 +26,7 @@
},
"tools": {
"Microsoft.AspNetCore.Razor.Tools": "1.0.0-*",
"Microsoft.DotNet.Watcher.Tools": "1.0.0-*",
"Microsoft.VisualStudio.Web.CodeGeneration.Tools": {
"imports": [
"portable-net45+win8"
],
"version": "1.0.0-*"
}
"Microsoft.DotNet.Watcher.Tools": "1.0.0-*"
},
"frameworks": {
"net451": {},
Expand All @@ -50,11 +36,7 @@
"version": "1.0.0-*",
"type": "platform"
}
},
"imports": [
"dotnet5.6",
"portable-net45+win8"
]
}
}
}
}

4 comments on commit cad72e7

@pranavkm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @dougbu. Scaffolding added Mvc tests. Having this in our samples causes cyclic dependencies on the CI.

@rynowak
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranavkm - what if we referenced 1.0.0 of the scaffolding tools?

@pranavkm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd have to modify Universe to support that. Right now, it just looks at the name of the reference.

@dougbu
Copy link
Member

@dougbu dougbu commented on cad72e7 Jul 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we having a conversation in a commit w/o a PR?
In any case, I'm fine reverting this part of a commit I did a bit ago (for convenience only).

Please sign in to comment.