During validation in DefaultBodyModelValidator if the modelAccessor of a model throws, it is not handled. #1206

sornaks · 2014-09-30T21:06:42Z

In WebApi this was handled by a ignoring validation for a hand-picked set of types and ignoring thrown exceptions. Should we stick to the same list? (The list seem to have been updated whenever a user reported a specific type is throwing.) Should we adopt a better way of handling this?
One thought after discussing with @pranavkm - Should we add a [DoNotValidate] attribute which ignore validation for the particular property and its children?

Fix: Introducing ExcludedValidationTypes in MvcOptions so that the user can exclude types which throw during Validation.

Fix: The MvcOptions takes in a list of Func<Type,bool>. This func verifies if the type is excluded in validation or not.

Fix: The MvcOptions takes in a list of ExcludeFromValidationDelegate (Func<Type,bool>). This func verifies if the type is excluded in validation or not.

sornaks · 2014-10-16T23:16:26Z

Checked in. 53379e4

sornaks added bug 1 - Ready needs design labels Sep 30, 2014

danroth27 added this to the 6.0.0-beta1 milestone Oct 8, 2014

danroth27 assigned sornaks Oct 9, 2014

danroth27 added 2 - Sprint Backlog and removed 1 - Ready labels Oct 9, 2014

sornaks added 2 - Working and removed 2 - Sprint Backlog labels Oct 10, 2014

sornaks pushed a commit that referenced this issue Oct 13, 2014

Issue #1206 - DefaultBodyModelValidator throws if get accessor throws.

1922b8a

Fix: Introducing ExcludedValidationTypes in MvcOptions so that the user can exclude types which throw during Validation.

sornaks mentioned this issue Oct 13, 2014

Issue #1206 - DefaultBodyModelValidator throws if get accessor throws. #1342

Closed

sornaks pushed a commit that referenced this issue Oct 14, 2014

Issue #1206 - DefaultBodyModelValidator throws if get accessor throws.

5346bf7

Fix: Introducing ExcludedValidationTypes in MvcOptions so that the user can exclude types which throw during Validation.

sornaks pushed a commit that referenced this issue Oct 15, 2014

Issue #1206 - DefaultBodyModelValidator throws if get accessor throws.

a5e1261

Fix: Introducing ExcludedValidationTypes in MvcOptions so that the user can exclude types which throw during Validation.

sornaks pushed a commit that referenced this issue Oct 16, 2014

Issue #1206 - DefaultBodyModelValidator throws if get accessor throws.

7853592

Fix: The MvcOptions takes in a list of Func<Type,bool>. This func verifies if the type is excluded in validation or not.

sornaks pushed a commit that referenced this issue Oct 16, 2014

Issue #1206 - DefaultBodyModelValidator throws if get accessor throws.

4221d58

Fix: The MvcOptions takes in a list of Func<Type,bool>. This func verifies if the type is excluded in validation or not.

sornaks closed this as completed Oct 16, 2014

sornaks added 3 - Done and removed 2 - Working labels Oct 16, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

During validation in DefaultBodyModelValidator if the modelAccessor of a model throws, it is not handled. #1206

During validation in DefaultBodyModelValidator if the modelAccessor of a model throws, it is not handled. #1206

sornaks commented Sep 30, 2014

sornaks commented Oct 16, 2014

During validation in DefaultBodyModelValidator if the modelAccessor of a model throws, it is not handled. #1206

During validation in DefaultBodyModelValidator if the modelAccessor of a model throws, it is not handled. #1206

Comments

sornaks commented Sep 30, 2014

sornaks commented Oct 16, 2014