Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Move authorization filters to be the first set of filters to run #1652

Closed
rynowak opened this issue Dec 1, 2014 · 3 comments
Closed

Move authorization filters to be the first set of filters to run #1652

rynowak opened this issue Dec 1, 2014 · 3 comments

Comments

@rynowak
Copy link
Member

rynowak commented Dec 1, 2014

Authorization filters come before the new resource filters stage, and are the first piece of user code to run after action selection.

Throwing from an authorization filter is considered a programming error, and will bubble up to middleware (not handled by exception filters).

See updated diagram:

@rynowak rynowak added this to the 6.0.0-beta2 milestone Dec 1, 2014
@pranavkm
Copy link
Contributor

pranavkm commented Dec 1, 2014

Out of curiosity, what would one do in a resource filter on the way out?

@rynowak rynowak self-assigned this Dec 1, 2014
rynowak added a commit that referenced this issue Dec 2, 2014
This change moves authorization filters to be the first filter stage
(before exception filters).
@rynowak
Copy link
Member Author

rynowak commented Dec 2, 2014

Out of curiosity, what would one do in a resource filter on the way out?

The same kinds of things you can do in a result filter... except a resource filter always runs. Result filters only run if a successful result was produced by the action or by an action filter.

rynowak added a commit that referenced this issue Dec 2, 2014
This change moves authorization filters to be the first filter stage
(before exception filters).
@rynowak
Copy link
Member Author

rynowak commented Dec 2, 2014

0152aac

@rynowak rynowak closed this as completed Dec 2, 2014
@rynowak rynowak added 3 - Done and removed 1 - Ready labels Dec 2, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants