Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Remove AddMvc overload with default parameter #1915

Closed
yishaigalatzer opened this issue Jan 29, 2015 · 1 comment
Closed

Remove AddMvc overload with default parameter #1915

yishaigalatzer opened this issue Jan 29, 2015 · 1 comment
Assignees
@sornaks
Labels
3 - Done bug
Milestone
1.0.0-beta4

Comments

@yishaigalatzer
Copy link
Contributor

We should avoid using default parameters in public APIs because they tend to block future changes by making for example adding an overload a breaking change.

CC // @Eilon This probably pops up in other repos
@yishaigalatzer yishaigalatzer added this to the 6.0.0-rc1 milestone Jan 29, 2015
sornaks pushed a commit that referenced this issue Feb 2, 2015
Bug #1915 - Remove AddMvc overload with default parameter.
cc998aa
sornaks pushed a commit that referenced this issue Feb 2, 2015
Bug #1915 - Remove AddMvc overload with default parameter.
a71e440
@sornaks sornaks mentioned this issue Feb 2, 2015
Closed
sornaks pushed a commit that referenced this issue Feb 4, 2015
Bug #1915 - Remove AddMvc overload with default parameter.
accf0c7
@sornaks
Copy link

sornaks commented Feb 4, 2015

accf0c7

@sornaks sornaks closed this as completed Feb 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sornaks sornaks

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-beta4
Development

No branches or pull requests
2 participants
@yishaigalatzer @sornaks