Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Form Collection Model Binder should not fall back to copying the form values from FormCollection #2527

Closed
Eilon opened this issue May 8, 2015 · 4 comments

Comments

@Eilon
Copy link
Member

Eilon commented May 8, 2015

This should get us one step closer to removing MVC's dependency on the concrete implementations of the HTTP abstractions. When fixing this bug, need to check if we can switch to depend just on the HTTP .Abstractions package.

@Eilon Eilon added this to the 6.0.0-beta5 milestone May 8, 2015
@danroth27 danroth27 modified the milestones: 6.0.0-beta6, 6.0.0-beta5 May 11, 2015
@Eilon Eilon assigned rynowak and unassigned ajaybhargavb Jul 8, 2015
@Eilon
Copy link
Member Author

Eilon commented Jul 8, 2015

@rynowak can you hold on to this and deal with it appropriately?

@rynowak
Copy link
Member

rynowak commented Jul 9, 2015

Yeah!

I'll say again what I've said the last few times this has come up:

We can't remove this reference because we create an empty FormCollection when there's nothing to bind for consistency with other collections.

There's some code cleanup to do here nonetheless. We all agree on removing support for FormCollection directly in user-code and the fallback to copy values.

@danroth27 danroth27 modified the milestones: 6.0.0-beta6, 6.0.0-beta7 Jul 16, 2015
@rynowak
Copy link
Member

rynowak commented Aug 6, 2015

Resolution here is to remove the fallback.

For the case where there's no form-data, MVC will provide an empty form collection (implemented in MVC).

@Eilon Eilon modified the milestones: 6.0.0-beta8, 6.0.0-beta7 Aug 7, 2015
rynowak added a commit that referenced this issue Aug 22, 2015
This removes the dependency on Microsoft.AspNet.Http from the Mvc.Core
code. Added the reference back to tests where needed (DefaultHttpContext).
@rynowak
Copy link
Member

rynowak commented Aug 24, 2015

1596cd9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants