Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Consider adding AddDataAnnotationsLocalization() overload to IMvcCoreBuilder #3517

Closed
NTaylorMullen opened this issue Nov 10, 2015 · 3 comments
Assignees
Milestone

Comments

@NTaylorMullen
Copy link
Member

Today when working with services.AddMvcCore() you don't get as consistent as an experience as working with services.AddMvc() as far as localization is concerned.

Currently we only provide 1 AddDataAnnotationsLocalization extension method for IMvcCoreBuilder:

AddDataAnnotationsLocalization(
    this IMvcCoreBuilder builder, 
    Action<MvcDataAnnotationsLocalizationOptions> setupAction)

Where the IMvcBuilder alternative has two, the above AND:

AddDataAnnotationsLocalization(this IMvcCoreBuilder builder)

All this results in you having to do the ugly:

services
    .AddMvcCore()
    .AddDataAnnotationsLocalization(null);
@Eilon Eilon added this to the 6.0.0-rc2 milestone Nov 11, 2015
@Eilon
Copy link
Member

Eilon commented Nov 11, 2015

@rynowak FYI

I think having the same overloads is probably fine, right?

@rynowak
Copy link
Member

rynowak commented Nov 11, 2015

👍

NTaylorMullen added a commit that referenced this issue Nov 11, 2015
- The `IMvcBuilder` extension methods already had this overload, just adding it to `IMvcCoreBuilder`.

#3517
NTaylorMullen added a commit that referenced this issue Nov 17, 2015
- The `IMvcBuilder` extension methods already had this overload, just adding it to `IMvcCoreBuilder`.

#3517
@NTaylorMullen
Copy link
Member Author

73f5570

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants