Localization of CompareAttribute should be localized

[Anderman]

The
_stringLocalizer[Attribute.ErrorMessage,displayName, GetOtherPropertyDisplayName(context)
Is missing
remarks

• To be consistent: Displayname and OtherPropertyName should also be localized

setup test

        [Compare(nameof(Password))]
        [Display(Name = "Email")]
        public string Email { get; set; }

        [Compare(nameof(Password), ErrorMessage = "{0} en {1} komen niet overeen(NL)")]
        [Display(Name = "PwPassword", ResourceType = typeof(loc))]

[NTaylorMullen]

This overlaps a bit with #3518

[Anderman]

Yeah, I totally agree that display name should be localized by the new _stringlocalizer

[Eilon]

Looks like this was fixed along with all the other attributes, here's the current code:

Mvc/src/Microsoft.AspNet.Mvc.DataAnnotations/CompareAttributeAdapter.cs

Lines 77 to 84 in 3393ba4

	public override string FormatErrorMessage(string name)
	{
	var displayName = ValidationContext.ModelMetadata.GetDisplayName();
	return string.Format(CultureInfo.CurrentCulture,
	ErrorMessageString,
	displayName,
	GetOtherPropertyDisplayName(ValidationContext, this));
	}