EventID's should be unique per-category

[ryanbrandenburg]

According to @BrennanConroy eventId's of LoggerMessage.Define should be unique per category (usually the T in ILogger<T>). There's some spots where that's not true and we should fix it. Example of non-uniqueness here.

[rynowak]

Our eventIds are unique per-logger. Where is this new requirement coming from?

[Eilon]

Yeah this is news to me. The uniqueness is (category + eventid), not just (eventid).

[ryanbrandenburg]

@BrennanConroy did I misunderstand the requirements here? And @Eilon what "category" are you talking about?

[Eilon]

The category is usually the type name we pass into ILogger<T>. The category names are arbitrary strings, but we pretty much always pass in the type name of the type doing the logging.

[ryanbrandenburg]

In that case isn't this and this as called here and here respectively an example of us not following (category + eventid) uniqueness since they'll use the same _logger?

[rynowak]

If we have a bug we should fix it.

But this statement has never been a practice we have followed:

EventId's of LoggerMessage.Define should be unique within thier package. This is certainly not the case right now, so we should go through and make them all so.

[Eilon]

@ryanbrandenburg that does appear to be a specific bug in that specific case.

[ryanbrandenburg]

Updated to reflect category vs package.

[Eilon]

Ok let's fix this one offending one. I can't think of a good way to easily detect this because there's no way to tell from the various LoggerExtension methods where the log will be used, and thus what the category is.