Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Move conventions defined in RazorPagesOptions to MvcOptions #6462

Closed
pranavkm opened this issue Jun 28, 2017 · 2 comments
Closed

Move conventions defined in RazorPagesOptions to MvcOptions #6462

pranavkm opened this issue Jun 28, 2017 · 2 comments
Assignees
@pranavkm
Labels
3 - Done feature-Razor-Pages
Projects
Razor Pages 2.0.0-preview3
Milestone
2.0.0

Comments

@pranavkm
Copy link
Contributor

RazorPageOptions defines collections of IPageRouteModelConventions and IPageApplicationModelConventions. These should be moved to MvcOptions.

Discussion #6417 (comment).
Related item #6461
@rynowak rynowak added this to the 2.0.0 milestone Jun 29, 2017
@pranavkm
Copy link
Contributor Author

pranavkm commented Jun 29, 2017 •
edited
Loading

Discussed offline and the plan is to have a marker interface IRazorPageConvention unifying the two types and leave them on RazorPagesOptions. We'll also have a custom collection type for IRazorPageConvention and retargeted the extension methods on RazorPagesOptionsExtensions that relate to conventions to this collection type.

@pranavkm
Copy link
Contributor Author

Fixed in #6470

pranavkm added a commit to aspnet/MvcPrecompilation that referenced this issue Jun 30, 2017
@pranavkm
Reacting to aspnet/Mvc#6462
d801bdc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
3 - Done feature-Razor-Pages
Projects
No open projects
Razor Pages 2.0.0-preview3
Done
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@pranavkm @rynowak