This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
LinkTagHelper & ScriptTagHelper now log view path #2063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| private readonly IEnumerable<KeyValuePair<string, object>> _values; | ||
|
|
||
|
solid, looks good to me. |
| return | ||
| string.Format($"Tag Helper {_uniqueId} had partial matches while determining mode:{newLine}\t{{0}}", | ||
| return string.Format( | ||
| $"Tag Helper with ID {_uniqueId} in view '{_viewPath}' had partial matches while determining mode:{newLine}\t{{0}}", |
There was a problem hiding this comment.
nit: this could be unrolled to avoid most of the additional $"..." / string.Format(...) nesting:
string.Format(
"Tag Helper with ID {0} in view '{1}' had partial matches while determining mode:{2}\t{{3}}",
_uniqueId,
_viewPath,
newline,
string.Join($"{newLine}\t", _partialMatches.Select(partial => string.Format(
"Mode '{0}' missing attributes:{1}\t\t{{2}} ",
partial.Mode,
newline,
string.Join($"{newLine}\t\t", partial.MissingAttributes)))));
|
|
DamianEdwards
force-pushed
the
enhancement-1949
branch
from
0ed3bd6
to
b3e4949
Compare
|
Merged in eef8884 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to
LinkTagHelperandScriptTagHelperto include the path of the current view when logging.@NTaylorMullen @yishaigalatzer @dougbu