This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Do not include compiler-generated names in expression names #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #2890 - add lots of `ExpressionHelper` tests using `IdFor()` and `NameFor()` (which are thin veneers)
|
|
||
| // If identifier contains "__", it is "reserved for use by the implementation" and likely compiler- | ||
| // or Razor-generated e.g. the name of a field in a delegate's generated class. | ||
| if (name.Contains("__")) |
There was a problem hiding this comment.
IIRC I double-checked me, and I was wrong. https://msdn.microsoft.com/en-us/library/aa664670(v=vs.71).aspx__ is only reserved at the start, might want to double check me.
Another way to verify this would probably to look at memberExpressionPart.Member and it's declaring class, which has [CompilerGenerated].
What we have here is probably good enough, but just in case we need to be more certain in the future.
|
|
looks good based on what I know about this code. if you're unsure, get 
dougbu
added a commit
to aspnet/AspNetWebStack
that referenced
this pull request
Mar 12, 2018
- #117 - see also aspnet/Mvc@a045324d3a and PR aspnet/Mvc#3027, the fix for aspnet/Mvc#2890 nits: copy some improved comments from aspnet/Mvc@a045324d3a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExpressionHelpertests usingIdFor()andNameFor()(which are thin veneers)