Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Order IgnoreAntiforgeryTokenAttribute and add test #5585

Merged
merged 1 commit into from Dec 12, 2016
Merged

Order IgnoreAntiforgeryTokenAttribute and add test #5585

merged 1 commit into from Dec 12, 2016

Conversation

ryanbrandenburg
Copy link
Contributor

Fixes #5552.

@ryanbrandenburg
Copy link
Contributor Author

@rynowak assigning this to you since you reviewed the last one.

rynowak
rynowak reviewed Dec 8, 2016
View reviewed changes
test/Microsoft.AspNetCore.Mvc.FunctionalTests/AntiforgeryAuthTests.cs
@@ -41,5 +41,15 @@ public AntiforgeryAuthTests(MvcTestFixture<Startup> fixture)
Assert.Equal(HttpStatusCode.Redirect, response.StatusCode);
Assert.Equal("/Home/Login", response.Headers.Location.AbsolutePath, StringComparer.OrdinalIgnoreCase);
}

[Fact]
public async Task IgnoreAntiforgeryBeforeAntiforgery()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not so much of a 'before' it's that the ignore overrides the auto.

@ryanbrandenburg ryanbrandenburg force-pushed the rybrande/IgnoreAntiforgeryTokenAttribute branch from 139f22b to b2340d3 Compare December 12, 2016 22:57
@ryanbrandenburg ryanbrandenburg merged commit b2340d3 into dev Dec 12, 2016
@ryanbrandenburg ryanbrandenburg deleted the rybrande/IgnoreAntiforgeryTokenAttribute branch February 16, 2017 23:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rynowak rynowak rynowak approved these changes

Assignees

@rynowak rynowak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryanbrandenburg @rynowak @dnfclas