This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Resolve path traversals in RazorViewEngine #5610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves the onus of path resolution from individual IFileProvider instances to RazorViewEngine. Fixes #5574 Fixes aspnet/MvcPrecompilation#33
Eilon
approved these changes
Dec 8, 2016
| } | ||
|
|
||
| var pathSegments = new List<StringSegment>(); | ||
| var tokenizer = new StringTokenizer(absolutePath, new[] { '/', '\\' }); |
There was a problem hiding this comment.
Can store the path separators in a static field.
| var viewEngine = CreateViewEngine(); | ||
|
|
||
| // Act | ||
| var result = viewEngine.GetAbsolutePath("/Index.cshtml", "../Shared/_Layout.cshtml"); |
There was a problem hiding this comment.
Can you add another case where the .. comes later, e.g. Foo/../Bar/../../Oops.cshtml?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the onus of path resolution from individual IFileProvider instances to RazorViewEngine.
Fixes #5574
Fixes aspnet/MvcPrecompilation#33