This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Add culture constructor to RouteValueProvider #5812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
reviewed
Feb 16, 2017
| /// <param name="bindingSource">The <see cref="BindingSource"/> of the data.</param> | ||
| /// <param name="values">The values.</param> | ||
| /// <param name="culture">The culture for route value.</param> | ||
| public RouteValueProvider(BindingSource bindingSource, RouteValueDictionary values, CultureInfo culture) |
There was a problem hiding this comment.
Please add to the docs for the other constructor that it will use the InvariantCulture.
rynowak
reviewed
Feb 16, 2017
| @@ -52,6 +69,8 @@ protected PrefixContainer PrefixContainer | |||
| } | |||
| } | |||
|
|
|||
| protected CultureInfo Culture { get; } = CultureInfo.InvariantCulture; | |||
There was a problem hiding this comment.
The general pattern when you have an optional constructor argument is to have the shorter constructor overload call the longer one and pass in the default value that way, rather than setting it directly on a property.
While this will work, it's going to catch someone out who's reading the code.
rynowak
reviewed
Feb 16, 2017
| @@ -21,10 +21,11 @@ public class RouteValueProvider : BindingSourceValueProvider | |||
| /// </summary> | |||
| /// <param name="bindingSource">The <see cref="BindingSource"/> of the data.</param> | |||
| /// <param name="values">The values.</param> | |||
| /// <remarks>Sets Culture to CultureInfo.InvariantCulture.</remarks> | |||
rynowak
approved these changes
Feb 16, 2017
ryanbrandenburg
force-pushed
the
rybrande/CultureOnRouteValueProvider
branch
from
ef46a0e
to
f667a7d
Compare
ryanbrandenburg
force-pushed
the
rybrande/CultureOnRouteValueProvider
branch
from
caf5b48
to
366dbde
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5336 using a similar format to ElementalValueProvider.