Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Page and Page model factory methods #6141

Merged
merged 1 commit into from Apr 17, 2017
Merged

Page and Page model factory methods #6141

merged 1 commit into from Apr 17, 2017

Conversation

ryanbrandenburg
Copy link
Contributor

Fixes #5846.

rynowak
rynowak reviewed Apr 15, 2017
View reviewed changes
src/Microsoft.AspNetCore.Mvc.RazorPages/Page.cs
@@ -232,6 +1009,71 @@ protected RedirectToPageResult RedirectToPagePermanent(string pageName, object r
=> new RedirectToPageResult(pageName, routeValues, permanent: true, fragment: fragment);

/// <summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO we need a RedirectToPage preserve method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RedirectToPageResult does not currently have a "preserve" property or constructor argument, so I assumed we didn't want a factory which considered it. If we should have that factory I'll add it and the property/ctor arg.

@ryanbrandenburg
Copy link
Contributor Author

🆙📅

@ryanbrandenburg ryanbrandenburg force-pushed the rybrande/PagePageModelFactoryMethods branch from 6ac7681 to c56b64f Compare April 17, 2017 23:12
@ryanbrandenburg ryanbrandenburg merged commit c56b64f into dev Apr 17, 2017
@ryanbrandenburg ryanbrandenburg deleted the rybrande/PagePageModelFactoryMethods branch April 17, 2017 23:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rynowak rynowak rynowak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryanbrandenburg @rynowak @dnfclas