Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Revert breaking change #6519

Merged
merged 2 commits into from
Jul 8, 2017
Merged

Revert breaking change #6519

merged 2 commits into from
Jul 8, 2017

Conversation

jbagga
Copy link
Contributor

@jbagga jbagga commented Jul 7, 2017

@rynowak
Copy link
Member

rynowak commented Jul 7, 2017

/cc @henkmollema - sadly we had to go with the extension method approach, this was too much of a breaking change 😭

@henkmollema
Copy link
Contributor

Aww, that's too bad. But no worries, I understand.

If I may ask, why is such a change not allowed for a major version? Is it just too big?

@jbagga
Copy link
Contributor Author

jbagga commented Jul 8, 2017

@rynowak @pranavkm Added null checks

@rynowak
Copy link
Member

rynowak commented Jul 8, 2017

If I may ask, why is such a change not allowed for a major version? Is it just too big?

It's technically allowed, but we found that this broke some existing libraries in a trivial way. Small breaking changes are the worst kind because the value add is small, but all of those libraries are still broken until they ship a new version.

@henkmollema
Copy link
Contributor

I see, thanks for the explanation.

@jbagga jbagga merged commit b4fe715 into dev Jul 8, 2017
@jbagga jbagga deleted the jbagga/ExtensionMethods6518 branch July 8, 2017 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants