Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Switch to using System.Runtime.InteropServices.RuntimeInformation where appropriate #34

Closed
analogrelay opened this issue Apr 13, 2016 · 12 comments
Assignees
Milestone

Comments

@analogrelay
Copy link
Contributor

(this can be done in RTM)

/cc @muratg

@Eilon
Copy link
Member

Eilon commented May 24, 2016

@BrennanConroy can you figure out what we need to do here?

@davidfowl
Copy link
Member

We can't do anything until we get new BCL packages.

@Eilon
Copy link
Member

Eilon commented May 24, 2016

Ok, hopefully today.

@muratg
Copy link

muratg commented May 25, 2016

This should be doable now.

@muratg
Copy link

muratg commented May 26, 2016

@BrennanConroy unblocked?

@BrennanConroy
Copy link
Member

Nope, we need to get the RC3 System.* packages

@natemcmaster
Copy link
Contributor

This is the cause of dotnet/efcore#5483

@BrennanConroy
Copy link
Member

BrennanConroy commented May 27, 2016

OSVersion isn't supported yet https://github.com/dotnet/corefx/issues/4741
RuntimeType does not exist in RuntimeInformation, we use if to test for CLR, CoreCLR, or Mono
https://github.com/dotnet/corefx/issues/8920

@pranavkm
Copy link
Contributor

@BrennanConroy where do we use those two properties?

@BrennanConroy
Copy link
Member

Testing, EntityFramework, MusicStore, Performance, Hosting

@BrennanConroy
Copy link
Member

Should I leave the spots that use OsVersion and RuntimeType and remove the references to the other types on the RuntimeEnvironment type?

@BrennanConroy
Copy link
Member

Done, will make an issue in Common for removing the RuntimeEnvironment.Sources package once RuntimeInformation has more features.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants