Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Add DisplayName to RequiredAttributeDescriptor #1119

Closed
NTaylorMullen opened this issue Mar 24, 2017 · 1 comment
Closed

Add DisplayName to RequiredAttributeDescriptor #1119

NTaylorMullen opened this issue Mar 24, 2017 · 1 comment

Comments

@NTaylorMullen
Copy link
Member

The Razor editor displays required attributes on HTML tags that have yet to be deemed a "TagHelper". These required attributes have a display which isn't always equal to the attributes required name. Example: If you do [HtmlTargetElement(Attributes = "asp-*")] you have a wildcard required attribute where the name comparison mode is prefix match. The display name for that required attribute should be asp-....

@NTaylorMullen NTaylorMullen added this to the 2.0.0-preview1 milestone Mar 24, 2017
@NTaylorMullen NTaylorMullen self-assigned this Mar 24, 2017
NTaylorMullen added a commit that referenced this issue Mar 24, 2017
- When `RequiredAttributeDescriptor`s are displayed in an editor their display name differs based on their name comparison mode. If their name comparison mode happens to be a prefix match then we need to append three dots to indicate that it's a required prefix for an attribute.
- Added a new descriptor builder test to validate `DisplayName` is created correctly.

#1119
NTaylorMullen added a commit that referenced this issue Mar 24, 2017
- When `RequiredAttributeDescriptor`s are displayed in an editor their display name differs based on their name comparison mode. If their name comparison mode happens to be a prefix match then we need to append three dots to indicate that it's a required prefix for an attribute.
- Added a new descriptor builder test to validate `DisplayName` is created correctly.

#1119
NTaylorMullen added a commit that referenced this issue Mar 24, 2017
- When `RequiredAttributeDescriptor`s are displayed in an editor their display name differs based on their name comparison mode. If their name comparison mode happens to be a prefix match then we need to append three dots to indicate that it's a required prefix for an attribute.
- Added a new descriptor builder test to validate `DisplayName` is created correctly.

#1119
@NTaylorMullen
Copy link
Member Author

ba55ee6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant