Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

GetTagHelpersGivenParent does not work when inspecting the root #1188

Closed
NTaylorMullen opened this issue Apr 6, 2017 · 1 comment
Closed
Assignees

Comments

@NTaylorMullen
Copy link
Member

NTaylorMullen commented Apr 6, 2017

Today we restrict the parent tag passed into GetTagHelpersGivenParent to not be null. However, if the parent doesn't exist then all TagHelpers without restricted parents are possible.

@NTaylorMullen NTaylorMullen added this to the 2.0.0-preview1 milestone Apr 6, 2017
@NTaylorMullen NTaylorMullen self-assigned this Apr 6, 2017
NTaylorMullen added a commit that referenced this issue Apr 6, 2017
- A `null` parent tag in all of our other API represents "any" parent tag, or in this case "root". Prior to this change we'd expect the caller to do their own verification of the parent and then assume all `TagHelperDescriptor`s are valid; this isn't sufficient because only our code base should have that knowledge.

#1188
NTaylorMullen added a commit that referenced this issue Apr 7, 2017
- A `null` parent tag in all of our other API represents "any" parent tag, or in this case "root". Prior to this change we'd expect the caller to do their own verification of the parent and then assume all `TagHelperDescriptor`s are valid; this isn't sufficient because only our code base should have that knowledge.

#1188
@NTaylorMullen
Copy link
Member Author

d47dc26

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant