Razor editor crash when typing @namespace directive line #1268

DamianEdwards · 2017-04-28T20:16:46Z

Using VS 2017 15.3 d15prerel 26427.6

Was adding @namespace RazorPagesSample.Pages.Blah to an existing page by typing it in manually in the editor, resulted in a crash. Pasting the complete line in worked OK.

The text was updated successfully, but these errors were encountered:

DamianEdwards · 2017-04-28T20:16:56Z

@rynowak @NTaylorMullen

rynowak · 2017-04-28T20:22:54Z

d15prerel 26421.06 had our earlier fix for the parsing of @page so this definitely is a new issue.

DamianEdwards · 2017-04-28T20:36:15Z

Stack trace:

System.Core.dll!System.Linq.Enumerable.First<Microsoft.AspNetCore.Razor.Language.Intermediate.DirectiveTokenIRNode>(System.Collections.Generic.IEnumerable<Microsoft.AspNetCore.Razor.Language.Intermediate.DirectiveTokenIRNode> source)	Unknown
 	Microsoft.AspNetCore.Mvc.Razor.Extensions.dll!Microsoft.AspNetCore.Mvc.Razor.Extensions.NamespaceDirective.TryComputeNamespace(string source, Microsoft.AspNetCore.Razor.Language.Intermediate.DirectiveIRNode directive, out string namespace)	Unknown
 	Microsoft.AspNetCore.Mvc.Razor.Extensions.dll!Microsoft.AspNetCore.Mvc.Razor.Extensions.NamespaceDirective.Pass.ExecuteCore(Microsoft.AspNetCore.Razor.Language.RazorCodeDocument codeDocument, Microsoft.AspNetCore.Razor.Language.Intermediate.DocumentIRNode irDocument)	Unknown
 	Microsoft.AspNetCore.Razor.Language.dll!Microsoft.AspNetCore.Razor.Language.RazorIRPassBase.Execute(Microsoft.AspNetCore.Razor.Language.RazorCodeDocument codeDocument, Microsoft.AspNetCore.Razor.Language.Intermediate.DocumentIRNode irDocument)	Unknown
 	Microsoft.AspNetCore.Razor.Language.dll!Microsoft.AspNetCore.Razor.Language.DefaultRazorDirectiveClassifierPhase.ExecuteCore(Microsoft.AspNetCore.Razor.Language.RazorCodeDocument codeDocument)	Unknown
 	Microsoft.AspNetCore.Razor.Language.dll!Microsoft.AspNetCore.Razor.Language.RazorEnginePhaseBase.Execute(Microsoft.AspNetCore.Razor.Language.RazorCodeDocument codeDocument)	Unknown
 	Microsoft.AspNetCore.Razor.Language.dll!Microsoft.AspNetCore.Razor.Language.DefaultRazorEngine.Process(Microsoft.AspNetCore.Razor.Language.RazorCodeDocument document)	Unknown
 	Microsoft.AspNetCore.Razor.Language.dll!Microsoft.AspNetCore.Razor.Language.RazorTemplateEngine.GenerateCode(Microsoft.AspNetCore.Razor.Language.RazorCodeDocument codeDocument)	Unknown
 	Microsoft.AspNetCore.Razor.Language.dll!Microsoft.AspNetCore.Razor.Language.Legacy.BackgroundParser.BackgroundThread.ParseChange(Microsoft.AspNetCore.Razor.Language.Legacy.ITextBuffer buffer, System.Threading.CancellationToken token)	Unknown
 	Microsoft.AspNetCore.Razor.Language.dll!Microsoft.AspNetCore.Razor.Language.Legacy.BackgroundParser.BackgroundThread.WorkerLoop()	Unknown
 	mscorlib.dll!System.Threading.ThreadHelper.ThreadStart_Context(object state)	Unknown
 	mscorlib.dll!System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, object state, bool preserveSyncCtx)	Unknown
 	mscorlib.dll!System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, object state, bool preserveSyncCtx)	Unknown
 	mscorlib.dll!System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, object state)	Unknown
 	mscorlib.dll!System.Threading.ThreadHelper.ThreadStart()	Unknown

rynowak · 2017-04-28T20:39:14Z

LOL I was about to post the same. Here's mine:

>	System.Core.dll!System.Linq.Enumerable.First<Microsoft.AspNetCore.Razor.Language.Intermediate.DirectiveTokenIRNode>(System.Collections.Generic.IEnumerable<Microsoft.AspNetCore.Razor.Language.Intermediate.DirectiveTokenIRNode> source)	Unknown
 	Microsoft.AspNetCore.Mvc.Razor.Extensions.dll!Microsoft.AspNetCore.Mvc.Razor.Extensions.NamespaceDirective.TryComputeNamespace(string source, Microsoft.AspNetCore.Razor.Language.Intermediate.DirectiveIRNode directive, out string namespace)	Unknown
 	Microsoft.AspNetCore.Mvc.Razor.Extensions.dll!Microsoft.AspNetCore.Mvc.Razor.Extensions.NamespaceDirective.Pass.ExecuteCore(Microsoft.AspNetCore.Razor.Language.RazorCodeDocument codeDocument, Microsoft.AspNetCore.Razor.Language.Intermediate.DocumentIRNode irDocument)	Unknown
 	Microsoft.AspNetCore.Razor.Language.dll!Microsoft.AspNetCore.Razor.Language.RazorIRPassBase.Execute(Microsoft.AspNetCore.Razor.Language.RazorCodeDocument codeDocument, Microsoft.AspNetCore.Razor.Language.Intermediate.DocumentIRNode irDocument)	Unknown
 	Microsoft.AspNetCore.Razor.Language.dll!Microsoft.AspNetCore.Razor.Language.DefaultRazorDirectiveClassifierPhase.ExecuteCore(Microsoft.AspNetCore.Razor.Language.RazorCodeDocument codeDocument)	Unknown
 	Microsoft.AspNetCore.Razor.Language.dll!Microsoft.AspNetCore.Razor.Language.RazorEnginePhaseBase.Execute(Microsoft.AspNetCore.Razor.Language.RazorCodeDocument codeDocument)	Unknown
 	Microsoft.AspNetCore.Razor.Language.dll!Microsoft.AspNetCore.Razor.Language.DefaultRazorEngine.Process(Microsoft.AspNetCore.Razor.Language.RazorCodeDocument document)	Unknown
 	Microsoft.AspNetCore.Razor.Language.dll!Microsoft.AspNetCore.Razor.Language.RazorTemplateEngine.GenerateCode(Microsoft.AspNetCore.Razor.Language.RazorCodeDocument codeDocument)	Unknown
 	Microsoft.AspNetCore.Razor.Language.dll!Microsoft.AspNetCore.Razor.Language.Legacy.BackgroundParser.BackgroundThread.ParseChange(Microsoft.AspNetCore.Razor.Language.Legacy.ITextBuffer buffer, System.Threading.CancellationToken token)	Unknown
 	Microsoft.AspNetCore.Razor.Language.dll!Microsoft.AspNetCore.Razor.Language.Legacy.BackgroundParser.BackgroundThread.WorkerLoop()	Unknown
 	mscorlib.dll!System.Threading.ThreadHelper.ThreadStart_Context(object state)	Unknown
 	mscorlib.dll!System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, object state, bool preserveSyncCtx)	Unknown
 	mscorlib.dll!System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, object state, bool preserveSyncCtx)	Unknown
 	mscorlib.dll!System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, object state)	Unknown
 	mscorlib.dll!System.Threading.ThreadHelper.ThreadStart()	Unknown

rynowak · 2017-04-28T20:39:56Z

The fix is here: https://github.com/aspnet/Razor/blob/dev/src/Microsoft.AspNetCore.Mvc.Razor.Extensions/NamespaceDirective.cs#L88 we need to be tolerant of invalid/incomplete parses.

- This involved not using the `First()` method when reading the directives tokens. - Added two tests to validate an empty directive token and a missed directive token for the `@namespace` directive. #1268

NTaylorMullen · 2017-04-29T00:14:57Z

86beea4

DamianEdwards · 2017-05-03T04:20:51Z

I don't see this fix in 2.0.0-preview1, only in dev...

rynowak · 2017-05-03T04:23:11Z

Our stabilization branch for 15.3P1 is https://github.com/aspnet/Razor/tree/preview-1/stabilization We're not mixing in any general 2.0.0-preview1 changes with VS work unless there's a good reason.

We could merge this to preview1 if we want just for safety, but I'm not aware of any runtime impact

DamianEdwards · 2017-05-03T04:29:08Z

Ok thanks, whatever you guys think is the right thing, just enumerating all the loose ends 😄

analogrelay · 2017-05-30T22:23:42Z

I'm getting a different error with the same repro:

Application: devenv.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.NullReferenceException
   at Microsoft.AspNetCore.Razor.Language.Legacy.CSharpCodeParser.HandleDirective(Microsoft.AspNetCore.Razor.Language.DirectiveDescriptor)
   at Microsoft.AspNetCore.Razor.Language.Legacy.CSharpCodeParser+<>c__DisplayClass93_0.<SetupDirectives>b__0()
   at Microsoft.AspNetCore.Razor.Language.Legacy.CSharpCodeParser.AfterTransition()
   at Microsoft.AspNetCore.Razor.Language.Legacy.CSharpCodeParser.AtTransition(Microsoft.AspNetCore.Razor.Language.Legacy.CSharpSymbol)
   at Microsoft.AspNetCore.Razor.Language.Legacy.CSharpCodeParser.ParseBlock()
   at Microsoft.AspNetCore.Razor.Language.Legacy.HtmlMarkupParser.OtherParserBlock()
   at Microsoft.AspNetCore.Razor.Language.Legacy.HtmlMarkupParser.SkipToAndParseCode(System.Func`2<Microsoft.AspNetCore.Razor.Language.Legacy.HtmlSymbol,Boolean>)
   at Microsoft.AspNetCore.Razor.Language.Legacy.HtmlMarkupParser.SkipToAndParseCode(Microsoft.AspNetCore.Razor.Language.Legacy.HtmlSymbolType)
   at Microsoft.AspNetCore.Razor.Language.Legacy.HtmlMarkupParser.ParseDocument()
   at Microsoft.AspNetCore.Razor.Language.Legacy.RazorParser.Parse(Microsoft.AspNetCore.Razor.Language.RazorSourceDocument)
   at Microsoft.AspNetCore.Razor.Language.RazorSyntaxTree.Parse(Microsoft.AspNetCore.Razor.Language.RazorSourceDocument, Microsoft.AspNetCore.Razor.Language.RazorParserOptions)
   at Microsoft.AspNetCore.Razor.Language.DefaultRazorParsingPhase.ExecuteCore(Microsoft.AspNetCore.Razor.Language.RazorCodeDocument)
   at Microsoft.AspNetCore.Razor.Language.RazorEnginePhaseBase.Execute(Microsoft.AspNetCore.Razor.Language.RazorCodeDocument)
   at Microsoft.AspNetCore.Razor.Language.DefaultRazorEngine.Process(Microsoft.AspNetCore.Razor.Language.RazorCodeDocument)
   at Microsoft.AspNetCore.Razor.Language.RazorTemplateEngine.GenerateCode(Microsoft.AspNetCore.Razor.Language.RazorCodeDocument)
   at Microsoft.AspNetCore.Razor.Language.Legacy.BackgroundParser+BackgroundThread.ParseChange(Microsoft.AspNetCore.Razor.Language.Legacy.ITextBuffer, System.Threading.CancellationToken)
   at Microsoft.AspNetCore.Razor.Language.Legacy.BackgroundParser+BackgroundThread.WorkerLoop()
   at System.Threading.ThreadHelper.ThreadStart_Context(System.Object)
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
   at System.Threading.ThreadHelper.ThreadStart()

It occurs when typing @namespace in the src/Hubbup.Web/Pages/_ViewImports.cshtml file in the anurse/namespace-directive-crash branch of https://github.com/anurse/ProjectKIssueList

(To clarify, despite the GIF showing a _PageImports.cshtml file, I did try and repro the error in _ViewImports.cshtml)

VS: 15.3.0 Preview 1.0 [26526.1.d15rel]

NTaylorMullen · 2017-05-30T22:31:07Z

Investigating

NTaylorMullen · 2017-05-30T23:12:20Z

@anurse I've filed a separate issue for this: #1393. Good find though!

rynowak added bug 1 - Ready labels Apr 28, 2017

rynowak assigned NTaylorMullen Apr 28, 2017

rynowak added this to the 2.0.0-preview1 milestone Apr 28, 2017

NTaylorMullen mentioned this issue Apr 29, 2017

Fix @namespace directive to handle incomplete directives. #1272

Merged

NTaylorMullen added 3 - Done and removed 1 - Ready labels Apr 29, 2017

NTaylorMullen closed this as completed Apr 29, 2017

analogrelay reopened this May 30, 2017

NTaylorMullen closed this as completed May 30, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Razor editor crash when typing @namespace directive line #1268

Razor editor crash when typing @namespace directive line #1268

DamianEdwards commented Apr 28, 2017

DamianEdwards commented Apr 28, 2017

rynowak commented Apr 28, 2017

DamianEdwards commented Apr 28, 2017

rynowak commented Apr 28, 2017

rynowak commented Apr 28, 2017 •

edited

Loading

NTaylorMullen commented Apr 29, 2017

DamianEdwards commented May 3, 2017

rynowak commented May 3, 2017 •

edited

Loading

DamianEdwards commented May 3, 2017

analogrelay commented May 30, 2017 •

edited

Loading

NTaylorMullen commented May 30, 2017

NTaylorMullen commented May 30, 2017

Razor editor crash when typing @namespace directive line #1268

Razor editor crash when typing @namespace directive line #1268

Comments

DamianEdwards commented Apr 28, 2017

DamianEdwards commented Apr 28, 2017

rynowak commented Apr 28, 2017

DamianEdwards commented Apr 28, 2017

rynowak commented Apr 28, 2017

rynowak commented Apr 28, 2017 • edited Loading

NTaylorMullen commented Apr 29, 2017

DamianEdwards commented May 3, 2017

rynowak commented May 3, 2017 • edited Loading

DamianEdwards commented May 3, 2017

analogrelay commented May 30, 2017 • edited Loading

NTaylorMullen commented May 30, 2017

NTaylorMullen commented May 30, 2017

rynowak commented Apr 28, 2017 •

edited

Loading

rynowak commented May 3, 2017 •

edited

Loading

analogrelay commented May 30, 2017 •

edited

Loading