Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Known Issues: Razor Tooling in VS 15.3 #1628

Closed
rynowak opened this issue Aug 17, 2017 · 9 comments
Closed

Known Issues: Razor Tooling in VS 15.3 #1628

rynowak opened this issue Aug 17, 2017 · 9 comments
Milestone

Comments

@rynowak
Copy link
Member

rynowak commented Aug 17, 2017

What's Broken?

Anyone that used our preview of the Razor Language Services and upgraded to Visual Studio 15.3 this week, you may find that the ASP.NET Core Razor editing experience has regressed.

This may include:

  • red squiggles for new things like @namespace and @page
  • tag helper colorization and completion missing

This is due to a conflict with the older Razor Language Services extension and the version that now ships as part of the Web Tools in the box.

You no longer need the marketplace-based extension to get the full Razor editing experience. it is included with Visual Studio 15.3.

If You Haven't Upgraded

If you haven't upgraded to 15.3 yet, you should remove the Razor Language Services extension before doing so. This will ensure that all of the old files are removed prior to getting the new version.

If You Are Already Broken

First of all, our apologies. We made a mistake in how we published the original extension to the marketplace. It was our goal from the beginning for this to upgrade smoothly and we didn't catch that this wasn't working.

If you are here, the best fix is to repair VS.

  1. Open the Visual Studio Installer
  2. Select your instance of Visual Studio
  3. Click More
  4. Click Repair

image

After Repair

If this it not working after a repair, please tell us about it here or via VS Feedback.

You should still see the see the 'Razor Language Services' extension as installed after doing a repair
image

@rynowak rynowak added this to the Discussions milestone Aug 17, 2017
@czmirek
Copy link

czmirek commented Aug 29, 2017

Repairing Visual Studio or even making a full reinstall does not make tag helpers colorization/completion work in 15.3.2. Razor Language Services is installed and enabled by default. Tried to disable it or uninstall it but I can't then open any cshtml file (see stackoverflow).

@NTaylorMullen
Copy link
Member

@czmotig if you type @page does it color yellow?

@czmirek
Copy link

czmirek commented Aug 29, 2017

Yes, @page is colored yellow. But I can't make TagHelpers work. I've created a new project in 15.3.3 which just got released, you can download it here.

  • example tag helper at "VisibilityTagHelper.cs" targets divs
  • _ViewImports.cshtml includes the namespace of that tag helper in @addTagHelper *, testapp.Code
  • yet editing any cshtml file and adding is-visible to any <div> does not show it in intellisense nor it is being colored...

@NTaylorMullen
Copy link
Member

@czmotig If you create a brand new web application does TagHelper IntelliSense light up for you? Also, to note, @addTagHelper doesn't consume namespaces, it consumes assembly names.

@czmirek
Copy link

czmirek commented Aug 29, 2017

I'm sorry it works now, I did not know @addTagHelper consumes assembly names :)

Edit: although Razor Language Services is still installed and enabled. Not sure if this is what you intended, since you advise to remove the extension before upgrading to 15.3

@rynowak
Copy link
Member Author

rynowak commented Aug 29, 2017

Not sure if this is what you intended, since you advise to remove the extension before upgrading to 15.3

Thanks for pointing this out. This is intended. I will update the main post to explain this.

@tomeks666
Copy link

tomeks666 commented Oct 13, 2017

I do not know if this is related to Razor Tooling or something else. I noticed that Wrap in Div (Alt-Shift-W) appears to have a bug. The opening div tag has 2 additional spaces

< div > <input/> </div>

This does not happen always. It happens when the wrapping is attempted in a code block following @using e.g.

@using(Html.BeginForm("Action", "Home") { < div > <Input /> </div> }

Could somebody try to reproduce it? Just put an input tag in a using block select it and press Alt-Shift-W

@rynowak
Copy link
Member Author

rynowak commented Oct 16, 2017

Hi @tomeks666 - moved your issue to https://github.com/aspnet/Razor/issues/1723

@rynowak
Copy link
Member Author

rynowak commented Oct 16, 2017

I'm closing and locking this issue because this provides a good summary of the issues with upgrading from the gallery extension -> VS 15.3

If you have other problems please open separate issues or post them to VS feedback

@rynowak rynowak closed this as completed Oct 16, 2017
@aspnet aspnet locked and limited conversation to collaborators Oct 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants