Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Using statements with SourceSpan set should generate line pragma #959

Closed
rynowak opened this issue Jan 27, 2017 · 0 comments
Closed

Using statements with SourceSpan set should generate line pragma #959

rynowak opened this issue Jan 27, 2017 · 0 comments
Assignees
@ajaybhargavb
Labels
3 - Done bug
Milestone
2.0.0-preview1

Comments

@rynowak
Copy link
Member

rynowak commented Jan 27, 2017

We don't currently test that the line mappings in runtime codegen match the source when it's coming from an import. I believe this is the cause of failures in the MVC test CompilationFailuresFromViewImportsAreListed
@Eilon Eilon added this to the 2.0.0 milestone Feb 1, 2017
ajaybhargavb added a commit that referenced this issue Feb 22, 2017
@ajaybhargavb
[Fixes #959] Generate LineMapping for Using statements with source
05d4980 
 - Also generate/test IR baselines with all code generation tests
@ajaybhargavb ajaybhargavb changed the title Add tests for codegen with imports Using statements with SourceSpan set should generate line pragma Feb 22, 2017
@ajaybhargavb ajaybhargavb added bug and removed task labels Feb 22, 2017
@ajaybhargavb ajaybhargavb mentioned this issue Feb 22, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajaybhargavb ajaybhargavb

Labels
3 - Done bug
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
3 participants
@Eilon @rynowak @ajaybhargavb