This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Don't render directive token from imports in design time #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaybhargavb
force-pushed
the
ajbaaska/imports
branch
from
ff05e67
to
16706fb
Compare
rynowak
reviewed
Mar 29, 2017
| @@ -110,8 +110,14 @@ public override void VisitDirectiveToken(DirectiveTokenIRNode node) | |||
| const string TypeHelper = "__typeHelper"; | |||
|
|
|||
| var tokenKind = node.Descriptor.Kind; | |||
| if (node.Source == null) | |||
| if (!node.Source.HasValue || | |||
| (Context.SourceDocument.FileName != null && | |||
There was a problem hiding this comment.
Why is the null check needed here? Is this a workaround for some test issue?
There was a problem hiding this comment.
It is just to handle the unlikely case of both of them being null.
There was a problem hiding this comment.
Just realized that doesn't matter. Will remove.
|
|
after removing silly null check
ajaybhargavb
force-pushed
the
ajbaaska/imports
branch
from
16706fb
to
c1500da
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #1138
@NTaylorMullen @rynowak