This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Generate line mappings for empty expressions. #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTaylorMullen
force-pushed
the
nimullen/emptyexpr.1155
branch
from
eedc4d6
to
192fda3
Compare
- At design time we weren't generating line mappings when a user would type `@` or `@(`. This results in no C# IntelliSense being provided to the user because the editor hasn't mapped any of Razor to the C# buffer. - Updated the design time renderer and design time writer to account for empty expressions. - Modified the `DefaultIRLoweringPhase` to set source locations on empty expression nodes. - Re-generated test files to account for 0 length line mappings on empty expression nodes. #1155
NTaylorMullen
force-pushed
the
nimullen/emptyexpr.1155
branch
from
192fda3
to
6209e90
Compare
|
Merging this now to unblock tooling folks. Feel free to review after it's been merged, I recommend doing so with |
ajaybhargavb
reviewed
Apr 3, 2017
Eh, "cleaned" it up when porting. Didn't realize it was needed. |
- looks fine
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@or@(. This results in no C# IntelliSense being provided to the user because the editor hasn't mapped any of Razor to the C# buffer.DefaultIRLoweringPhaseto set source locations on empty expression nodes.#1155