This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Update TagHelperMatchingConventions to disallow opt-out prefix. #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
reviewed
Apr 6, 2017
| @@ -66,6 +68,12 @@ public static bool SatisfiesTagName(string tagNameWithoutPrefix, TagMatchingRule | |||
| throw new ArgumentNullException(nameof(rule)); | |||
| } | |||
|
|
|||
| if (tagNameWithoutPrefix.Length > 0 && tagNameWithoutPrefix[0] == ElementOptOutCharacter) | |||
There was a problem hiding this comment.
Should we just reject anything with length == 0?
rynowak
approved these changes
Apr 6, 2017
ajaybhargavb
approved these changes
Apr 6, 2017
| @@ -66,6 +68,12 @@ public static bool SatisfiesTagName(string tagNameWithoutPrefix, TagMatchingRule | |||
| throw new ArgumentNullException(nameof(rule)); | |||
| } | |||
|
|
|||
| if (tagNameWithoutPrefix.Length > 0 && tagNameWithoutPrefix[0] == ElementOptOutCharacter) | |||
| { | |||
| // TagHelper's can never satisfy tag names that are prefixed with the opt-out character. | |||
- Prior to this change the `TagHelper` parsing would strip the opt-out character (`!`) from tag names that got passed to the TagHelper matching services. At design time this proved to be a problem because they have their own understanding of the HTML document and only pass us full tag names (names that include `!`). This changes the matching conventions to immediately return false if a tag name is seen to contain the `TagHelper` opt-out. - Added two `DefaultTagHelperFactService` tests to verify that tag names with opt-out prefixes are denied `TagHelperDescriptor`s. #1186
NTaylorMullen
force-pushed
the
nimullen/thfs.1186
branch
from
1874b07
to
0005cb9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TagHelperparsing would strip the opt-out character (!) from tag names that got passed to the TagHelper matching services. At design time this proved to be a problem because they have their own understanding of the HTML document and only pass us full tag names (names that include!). This changes the matching conventions to immediately return false if a tag name is seen to contain theTagHelperopt-out.DefaultTagHelperFactServicetests to verify that tag names with opt-out prefixes are deniedTagHelperDescriptors.#1186