Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Make extensible directive type token rendering allow value types. #1353

Merged
merged 1 commit into from
May 17, 2017
Merged

Make extensible directive type token rendering allow value types. #1353

merged 1 commit into from
May 17, 2017

Conversation

NTaylorMullen
Copy link
Member

  • Instead of rendering a null assigning statement for a type token we now render a default(TTypeToken). With this approach type tokens can be value types without creating a design time error.
  • Re-generated baseline files to reflect new directive token code generation.

#1176

@NTaylorMullen NTaylorMullen changed the base branch from nimullen/1351 to dev May 17, 2017 17:23
@NTaylorMullen NTaylorMullen changed the base branch from dev to rel/15.3 May 17, 2017 17:24
@NTaylorMullen
Make extensible directive type token rendering allow value types.
c8df25f 
- Instead of rendering a null assigning statement for a type token we now render a `default(TTypeToken)`. With this approach type tokens can be value types without creating a design time error.
- Re-generated baseline files to reflect new directive token code generation.

#1176
@NTaylorMullen NTaylorMullen merged commit b8ea008 into rel/15.3 May 17, 2017
@NTaylorMullen NTaylorMullen deleted the nimullen/1176 branch May 17, 2017 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rynowak rynowak rynowak approved these changes

@ajaybhargavb ajaybhargavb Awaiting requested review from ajaybhargavb

Assignees

@rynowak rynowak

@ajaybhargavb ajaybhargavb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NTaylorMullen @rynowak @ajaybhargavb @dnfclas