This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Added TagHelper support for enums.
#585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,6 +56,12 @@ public class TagHelperAttributeValueCodeRenderer | |||
| throw new ArgumentNullException(nameof(renderAttributeValue)); | |||
| } | |||
|
|
|||
| if (attributeDescriptor.IsEnum && !complexValue) | |||
| { | |||
| writer.Write(attributeDescriptor.TypeName) | |||
There was a problem hiding this comment.
Should this be the FullName? Same class of issue as #580
There was a problem hiding this comment.
TypeName is the equivalent to FullName
|
Bump |
|
|
| @@ -56,6 +56,12 @@ public class TagHelperAttributeValueCodeRenderer | |||
| throw new ArgumentNullException(nameof(renderAttributeValue)); | |||
| } | |||
|
|
|||
| if (attributeDescriptor.IsEnum && !complexValue) | |||
There was a problem hiding this comment.
This class is used three times in CSharpTagHelperCodeRenderer but the new code is relevant only for CSharpTagHelperCodeRenderer.RenderRawAttributeValue(). Suggest moving this addition there.
|
⌚ for one location question and MVC reaction PR. |
|
🆙 📅 MVC Pr: aspnet/Mvc#3435 |
| // So quoting or buffering are not helpful. | ||
| RenderRawAttributeValue(attributeValueChunk, attributeDescriptor, isPlainTextValue); | ||
| RenderCodeAttributeValue(attributeValueChunk, attributeDescriptor, isPlainTextValue); |
|
|
- If a `TagHelper` attribute is an `enum` then you no longer need to provide the `enum` name. To override this functionality you can add the `@` symbol. - Added code generation tests. - Added `TagHelperDescriptorFactoryTest`s that double for Precompilation tests. #196
NTaylorMullen
force-pushed
the
nimullen/enumsupport.196
branch
from
81be8c2
to
22ecf85
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TagHelperattribute is anenumthen you no longer need to provide theenumname. To override this functionality you can add the@symbol.TagHelperDescriptorFactoryTests that double for Precompilation tests.Tag Helpers: Add enum attribute support. #196