This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Fixed unsafe cast in CSharpCodeVisitor #813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -399,29 +399,38 @@ protected override void Visit(SectionChunk chunk) | |||
|
|
|||
| public void RenderDesignTimeExpressionBlockChunk(ExpressionBlockChunk chunk) | |||
| { | |||
| var firstChild = (ExpressionChunk)chunk.Children.FirstOrDefault(); | |||
|
|
|||
| var firstChild = chunk.Children.FirstOrDefault(); | |||
| if (firstChild != null) | |||
There was a problem hiding this comment.
I know you didn't write this but since we're touching bits around this; to avoid lots of indentation lets do:
if (firstChild == null)
{
return;
}
|
🆙 📅 |
|
|
| else | ||
| { | ||
| // First child is not an expression chunk | ||
| Accept(chunk.Children.ToList()); |
ajaybhargavb
force-pushed
the
ajbaaska/vs-crash-fix
branch
from
1deebff
to
f09e2bf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #804
@NTaylorMullen