This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Add support for optional directives #977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unblocks #968 scenarios for Razor pages |
NTaylorMullen
suggested changes
Feb 8, 2017
| @@ -35,39 +37,58 @@ public DefaultDirectiveDescriptorBuilder(string name, DirectiveDescriptorKind ty | |||
| _tokenDescriptors = new List<DirectiveTokenDescriptor>(); | |||
| } | |||
|
|
|||
| public IDirectiveDescriptorBuilder AddType() | |||
| public IDirectiveDescriptorBuilder AddType(bool optional) | |||
There was a problem hiding this comment.
Instead of having each API specify whether its optional or not we could make an API that direct the user into a state where they can't fail easily. Aka:
builder
.AddType()
.RemainingTokensOptional()
.AddString()
.AddMember();
And
builder
.AddType()
.RemainingTokensOptional()
.AddString()
.RemainingTokensOptional() // Explode
.AddMember();
We all know I'm horrible at naming choices but you get the gist 😄.
There was a problem hiding this comment.
Sure, sounds work-able.
| @@ -1549,7 +1553,13 @@ private void HandleDirective(DirectiveDescriptor descriptor) | |||
| outputKind = SpanKind.Code; | |||
| break; | |||
| case DirectiveTokenKind.String: | |||
| AcceptAndMoveNext(); | |||
| if (!AcceptAndMoveNext()) | |||
There was a problem hiding this comment.
AcceptAndMoveNext() fails only at EOF right?
| @@ -734,6 +734,23 @@ public void SectionDirective() | |||
| .Accepts(AcceptedCharacters.None))); | |||
| } | |||
|
|
|||
| [Fact(Skip = "I don't know how to write Razor tests"] | |||
pranavkm
force-pushed
the
prkrishn/968
branch
from
4946cca
to
4621cc1
Compare
|
🆙 📅 Getting this in to unblock Mvc. We can rev on the design \ code in the PR for #968 |
NTaylorMullen
approved these changes
Feb 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.