Skip to content
This repository has been archived by the owner on Feb 23, 2021. It is now read-only.

Refactor code to enable testing on CoreCLR #30

Closed
cesarblum opened this issue Oct 21, 2015 · 2 comments
Closed

Refactor code to enable testing on CoreCLR #30

cesarblum opened this issue Oct 21, 2015 · 2 comments
Assignees
@NTaylorMullen
Labels
3 - Done Fundamentals task
Milestone
1.0.0-preview1

Comments

@cesarblum
Copy link
Contributor

Add this to test\Microsoft.AspNet.Tooling.Razor.Test\project.json:

"dnxcore50": {
  "dependencies": {
    "System.Dynamic.Runtime": "4.0.11-beta-*"
  }
}

Two code changes are necessary:

  • In RazorPluginTest.cs, use Type.GetTypeInfo().Assembly instead of Type.Assembly.
  • It is not possible to subclass Assembly in CoreCLR. Change the code to use an interface instead of direcly using Assembly objects.

This is related to aspnet/Universe#304.
@Eilon Eilon added this to the 1.0.0-rc2 milestone Oct 30, 2015
@NTaylorMullen
Copy link
Member

Going to complete #25 prior to this since the code will be drastically changing

NTaylorMullen added a commit that referenced this issue Dec 12, 2015
@NTaylorMullen
Update RazorTooling to run on CoreCLR on other platforms asides from …
5a469ad 
…Windows.

- Refactored classes to not require inheriting from `Assembly`. It's not available on CoreCLR.

#30
@NTaylorMullen NTaylorMullen mentioned this issue Dec 12, 2015
Merged
@NTaylorMullen
Copy link
Member

5a469ad

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
3 - Done Fundamentals task
Projects
None yet
Milestone
1.0.0-preview1
Development

No branches or pull requests
4 participants
@Eilon @cesarblum @muratg @NTaylorMullen