This repository has been archived by the owner on Feb 23, 2021. It is now read-only.
React to aspnet/Razor#196 - Maintain VisualStudioCompatibility Test. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @dougbu |
NTaylorMullen
changed the title
NTaylorMullen
force-pushed
the
nimullen/razor.enumsupport.196
branch
from
6de03a2
to
76bf9eb
Compare
| var dtAttribute = attribute.DesignTimeDescriptor; | ||
| var expectedDTAttribute = expectedAttribute.DesignTimeDescriptor; | ||
| Assert.Equal(dtAttribute.Remarks, expectedDTAttribute.Remarks, StringComparer.Ordinal); | ||
| Assert.Equal(dtAttribute.Summary, expectedDTAttribute.Summary, StringComparer.Ordinal); |
There was a problem hiding this comment.
Can't this be done more simply with a comparator and the IEnumerable assertions?
There was a problem hiding this comment.
Ehh, I could make a comparator. A bit heavy handed for this though.
There was a problem hiding this comment.
Well, this is a pretty ugly block of assertions but 🆗
|
⌚ |
|
🆙 📅 by ordering attribute descriptors |
|
|
once we see the
|
It builds 😄. Checking this in now. |
- Add new `IsEnum` `TagHelperDescriptor` property to VS compatibility test.
NTaylorMullen
force-pushed
the
nimullen/razor.enumsupport.196
branch
from
4cfd2c3
to
747b1b3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsEnumTagHelperDescriptorproperty to VS compatibility test.